Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border radius for wiki pages #29937

Merged
merged 4 commits into from Mar 22, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 20, 2024

Before

image

After

image

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Mar 20, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 20, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 20, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 20, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 20, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 20, 2024
@wxiaoguang
Copy link
Contributor

Why only add these borders? I can see there are more <div class="markup below.

Since it is used many times, maybe it's better to write the style to CSS .wiki-content-parts .markup ?

@silverwind silverwind self-requested a review March 20, 2024 14:48
@silverwind
Copy link
Member

silverwind commented Mar 20, 2024

Agree, something like

.wiki-content-parts .markup {
  border-radius: var(--border-radius);
}

may be better to also fix the other .markup elements, when they appear. Or add tw-rounded to all of them.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Mar 20, 2024
@github-actions github-actions bot added modifies/frontend and removed modifies/templates This PR modifies the template files labels Mar 21, 2024
@lunny
Copy link
Member Author

lunny commented Mar 21, 2024

Agree, something like

.wiki-content-parts .markup {
  border-radius: var(--border-radius);
}

may be better to also fix the other .markup elements, when they appear. Or add tw-rounded to all of them.

4a18d81

I haven't found other places that have no rounded just wiki pages.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 22, 2024
@silverwind silverwind enabled auto-merge (squash) March 22, 2024 13:12
@silverwind silverwind merged commit 0c55506 into go-gitea:main Mar 22, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 22, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 22, 2024
@lunny lunny deleted the lunny/wiki_borderradius branch March 22, 2024 13:21
@6543 6543 modified the milestones: 1.23.0, 1.22.0 Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants