Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Descriptions about ENABLE_OPENID_SIGNIN are not aligned #29923

Closed
fengli320 opened this issue Mar 20, 2024 · 0 comments · Fixed by #29925
Closed

Descriptions about ENABLE_OPENID_SIGNIN are not aligned #29923

fengli320 opened this issue Mar 20, 2024 · 0 comments · Fixed by #29925
Labels
type/bug type/docs This PR mainly updates/creates documentation
Milestone
1.21.9

Comments

@fengli320
Copy link

Description

In cheat sheet page(https://docs.gitea.com/administration/config-cheat-sheet), there is such description:

ENABLE_OPENID_SIGNIN: false: Allow authentication in via OpenID.

But in example app.ini (https://github.com/go-gitea/gitea/blob/main/custom/conf/app.example.ini), the description about OpenID is:

;; Whether to allow signin in via OpenID
;ENABLE_OPENID_SIGNIN = true

And with Gitea 1.21.3, "Enable OpenID Sign-In" is enabled by default on installation page.

These descriptions should be aligned.

Gitea Version

1.21.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

No response

How are you running Gitea?

in Linux container

Database

SQLite
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Mar 20, 2024
@lunny lunny mentioned this issue Mar 20, 2024
Merged
lunny added a commit that referenced this issue Mar 20, 2024
@lunny
Fix the wrong default value of ENABLE_OPENID_SIGNIN on docs (#29925)
02bbdd4 
Fix #29923
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 20, 2024
@lunny @GiteaBot
Fix the wrong default value of ENABLE_OPENID_SIGNIN on docs (go-gitea…
59708f8 
…#29925)

Fix go-gitea#29923
@GiteaBot GiteaBot mentioned this issue Mar 20, 2024
Merged
@lunny lunny added this to the 1.21.9 milestone Mar 20, 2024
lunny added a commit that referenced this issue Mar 20, 2024
@GiteaBot @lunny
Fix the wrong default value of ENABLE_OPENID_SIGNIN on docs (#29925) (#…
eb302de 
…29927)

Backport #29925 by @lunny

Fix #29923

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.21.9
Development

Successfully merging a pull request may close this issue.

Fix the wrong default value of ENABLE_OPENID_SIGNIN on docs lunny/gitea
2 participants
@lunny @fengli320