Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various loading states, remove .loading class #29920

Merged
merged 3 commits into from Mar 21, 2024
Merged

Fix various loading states, remove .loading class #29920

merged 3 commits into from Mar 21, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 19, 2024 •
edited

Various code was using fomantic loading class which I think got broken a while ago and rendered only a full circle. Fix those to use is-loading.

Before:
Screenshot 2024-03-19 at 22 56 26

After:
Screenshot 2024-03-19 at 22 54 35
Screenshot 2024-03-19 at 22 54 56
Screenshot 2024-03-19 at 22 55 16
Screenshot 2024-03-19 at 23 01 43
Screenshot 2024-03-19 at 23 56 25
Screenshot 2024-03-20 at 00 00 38

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2024
@github-actions github-actions bot added modifies/frontend modifies/templates This PR modifies the template files modifies/js labels Mar 19, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2024
@silverwind silverwind changed the title Fix various js loading states Fix various loading states, remove .loading class Mar 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2024
@silverwind
Copy link
Member Author

Couldn't find this loading class anywhere in our code, so it should be safe to remove now. At least I think fomantic wouldn't automatically add it, the only remaining case would be some .loading() or something, I will search a bit more.

@silverwind
Copy link
Member Author

Didn't find anything, so should be safe.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 21, 2024
@silverwind silverwind enabled auto-merge (squash) March 21, 2024 16:05
@silverwind silverwind merged commit d6fed9a into go-gitea:main Mar 21, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 21, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 21, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 21, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into npmlink
62b58d5 
* origin/main: (332 commits)
  Refactor external URL detection (go-gitea#29973)
  Refactor repo header/list (go-gitea#29969)
  Fix various loading states, remove `.loading` class (go-gitea#29920)
  Update register application URL for GitLab (go-gitea#29959)
  Refactor StringsToInt64s (go-gitea#29967)
  Switch to happy-dom for testing (go-gitea#29948)
  Performance improvements for pull request list page (go-gitea#29900)
  Refactor URL detection (go-gitea#29960)
  Solving the issue of UI disruption when the review is deleted without refreshing (go-gitea#29951)
  Fix JS error and improve error message styles (go-gitea#29963)
  Fix the bug that user may logout if he switch pages too fast (go-gitea#29962)
  Cancel previous runs of the same PR automatically (go-gitea#29961)
  Exclude `routers/private/tests` from air (go-gitea#29949)
  Remove codecov badge (go-gitea#29950)
  Misc color tweaks (go-gitea#29943)
  Fix and rewrite markup anchor processing (go-gitea#29931)
  Remove fomantic grid module (go-gitea#29894)
  Add background to dashboard navbar, fix missing padding (go-gitea#29940)
  Prevent layout shift in `<overflow-menu>` items (go-gitea#29831)
  Fix loadOneBranch panic (go-gitea#29938)
  ...
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 22, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
3597d77 
* giteaofficial/main:
  Fix bugs in rerunning jobs (go-gitea#29955)
  remove PATH and GOPATH modification in Makefile (go-gitea#29978)
  Refactor external URL detection (go-gitea#29973)
  Refactor repo header/list (go-gitea#29969)
  Fix various loading states, remove `.loading` class (go-gitea#29920)
  Update register application URL for GitLab (go-gitea#29959)
  Refactor StringsToInt64s (go-gitea#29967)
  Switch to happy-dom for testing (go-gitea#29948)
  Performance improvements for pull request list page (go-gitea#29900)
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 22, 2024
@silverwind silverwind mentioned this pull request Mar 27, 2024
Merged
silverwind added a commit that referenced this pull request Mar 27, 2024
@silverwind
Fix download buttons on branches page (#30147)
c85619b 
Fixes #30143, regression from
#29920.

We have `.button` on the repo page, but on the branch page it's a
`.btn`. Eventually we should find a solution to have a single button
class but until then this solution should be acceptable.
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Mar 30, 2024
@silverwind @earl-warren
Fix download buttons on branches page (#30147)
8d2b764 
Fixes go-gitea/gitea#30143, regression from
go-gitea/gitea#29920.

We have `.button` on the repo page, but on the branch page it's a
`.btn`. Eventually we should find a solution to have a single button
class but until then this solution should be acceptable.

(cherry picked from commit c85619b82d19a928cb219eba3f38473928b29b0c)
@wxiaoguang wxiaoguang mentioned this pull request Apr 17, 2024
Merged
wxiaoguang added a commit that referenced this pull request Apr 18, 2024
@wxiaoguang @GiteaBot
Refactor and fix archive link bug (#30535)
d0e0708 
Regression of #29920
Fixes: #30569

Also this is a rewriting to eliminate the remaining jQuery usages from code.

Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request Apr 18, 2024
@wxiaoguang @GiteaBot
Refactor and fix archive link bug (go-gitea#30535)
3b018ee 
Regression of go-gitea#29920
Fixes: go-gitea#30569

Also this is a rewriting to eliminate the remaining jQuery usages from code.

Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot mentioned this pull request Apr 18, 2024
Merged
silverwind added a commit that referenced this pull request Apr 21, 2024
@GiteaBot @wxiaoguang @silverwind
Refactor and fix archive link bug (#30535) (#30570)
fc376c8 
Backport #30535 by wxiaoguang

Regression of #29920
Fixes: #30569

Also this is a rewriting to eliminate the remaining jQuery usages from
code.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @wxiaoguang @delvh @lunny @GiteaBot