Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix border on focus in dashboard repo search #29893

Merged
merged 3 commits into from Mar 19, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 18, 2024

Before:

Screenshot 2024-03-18 at 22 35 10

After:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 18, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 18, 2024
@silverwind
Copy link
Member Author

Apparently the order icon after input is the one fomantic documents and the changes makes the icon no longer highlight correctly on focus. Looking for other solutions...

@silverwind
Copy link
Member Author

Fixed and removed a useless transition on the icon as well.

@silverwind silverwind changed the title Fix border-right on focus in dashboard repo search Fix border on focus in dashboard repo search Mar 18, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 18, 2024
@wxiaoguang
Copy link
Contributor

I do not think it needs to be that complex.

It could be simple fixed by moving the "icon" ahead the "input", without adding more CSS styles.

image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2024
@silverwind
Copy link
Member Author

silverwind commented Mar 19, 2024

It could be simple fixed by moving the "icon" ahead the "input", without adding more CSS styles.

That's what I had initially but that breaks the focus style of the icon because Fomantic only supports input before icon:

.ui.icon.input > textarea:focus ~ i.icon,
.ui.icon.input > input:focus ~ i.icon {
  opacity: 1;
}

Second selector no longer works after swapping the item first and the problem is visible in the screenshot as well where the icon is not fully opaque.

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 19, 2024
@silverwind silverwind enabled auto-merge (squash) March 19, 2024 10:32
@silverwind silverwind merged commit 5a8559e into go-gitea:main Mar 19, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 19, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 19, 2024
@silverwind silverwind deleted the bordersearch branch March 19, 2024 11:01
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants