Improve branch select list ui in go templates

[HEREYUA]

Relate:#27417
Reference: #26631

Before

After

[silverwind]

Sorry, but I have to raise this: Why create a duplicate translation string?

issues.no_results = No results found.
pulls.no_results = No results found.

This will lead to unnecessary work for the translators. Either keep the old key or move to non-namespaced key no_results_found.

[HEREYUA]

This CSS was quite a mess formatting wise, I see we need to tighten the linter rules 😆

I'm sorry, I will pay more attention in the future

[HEREYUA]

@HEREYUA would you be interested in merging these two into one in another PR? I will approve this PR with with some remorse.

I will try it

[silverwind]

Let's fix #29729 (comment), then we can merge this PR.

[HEREYUA]

Let's fix #29729 (comment), then we can merge this PR.

updated, but should the places using pulls.no_results be modified to use no_result_found, does this need to be modified in another PR?

[silverwind]

I would say do the renames here. I found these places:

rg pulls.no_results | grep -v options
templates/repo/issue/view_title.tmpl:           <div class="ui floating filter dropdown" data-no-results="{{ctx.Locale.Tr "repo.pulls.no_results"}}">
templates/repo/issue/branch_selector_field.tmpl:<div class="ui {{if not .HasIssuesOrPullsWritePermission}}disabled{{end}} floating filter select-branch dropdown" data-no-results="{{ctx.Locale.Tr "repo.pulls.no_results"}}">
templates/repo/diff/compare.tmpl:   <div class="ui floating filter dropdown" data-no-results="{{ctx.Locale.Tr "repo.pulls.no_results"}}">
templates/repo/wiki/view.tmpl:        <div class="ui floating filter dropdown" data-no-results="{{ctx.Locale.Tr "repo.pulls.no_results"}}">
templates/repo/branch_dropdown.tmpl:    'noResults': {{ctx.Locale.Tr "repo.pulls.no_results"}},

[HEREYUA]

I would say do the renames here. I found these places:

rg pulls.no_results | grep -v options
templates/repo/issue/view_title.tmpl:           <div class="ui floating filter dropdown" data-no-results="{{ctx.Locale.Tr "repo.pulls.no_results"}}">
templates/repo/issue/branch_selector_field.tmpl:<div class="ui {{if not .HasIssuesOrPullsWritePermission}}disabled{{end}} floating filter select-branch dropdown" data-no-results="{{ctx.Locale.Tr "repo.pulls.no_results"}}">
templates/repo/diff/compare.tmpl:   <div class="ui floating filter dropdown" data-no-results="{{ctx.Locale.Tr "repo.pulls.no_results"}}">
templates/repo/wiki/view.tmpl:        <div class="ui floating filter dropdown" data-no-results="{{ctx.Locale.Tr "repo.pulls.no_results"}}">
templates/repo/branch_dropdown.tmpl:    'noResults': {{ctx.Locale.Tr "repo.pulls.no_results"}},

Okay, I'll make the changes right away.

[silverwind]

Ok, remove pulls.no_results from the en_US file when done.

[HEREYUA]

Ok, remove pulls.no_results from the en_US file when done.

done