Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine fuzziness of bleve indexer by keyword length #29706

Merged
merged 18 commits into from Mar 23, 2024
Merged

Determine fuzziness of bleve indexer by keyword length #29706

merged 18 commits into from Mar 23, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 10, 2024 •
edited

also bleve did match on fuzzy search and the other way around. this also fix that bug.

@6543 6543 added the type/enhancement An improvement of existing functionality label Mar 10, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 10, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 10, 2024
@6543 6543 added the type/bug label Mar 11, 2024
@6543 6543 added this to the 1.22.0 milestone Mar 11, 2024
@6543 6543 requested a review from a team March 11, 2024 15:06
@6543
Copy link
Member Author

6543 commented Mar 11, 2024

PS: if we dont want that simple enhancement in v1.22.0 I can extract the bugfix, but I would prefere to simply have this fixed and enhanced ;)

@6543 6543 mentioned this pull request Mar 12, 2024
Merged
@6543
Copy link
Member Author

6543 commented Mar 12, 2024

@lunny ☝️

@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 14, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 15, 2024
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 15, 2024
lunny
lunny previously requested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per https://github.com/go-gitea/gitea/pull/29706/files#r1525990208

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Mar 15, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Mar 18, 2024
@6543
Copy link
Member Author

6543 commented Mar 23, 2024

☝️ fixing via mobile sucks :/

@KN4CK3R
Copy link
Member

KN4CK3R commented Mar 23, 2024

Then don't do it. I don't need 20 notifications. 🙂

@6543 6543 merged commit b9c57fb into go-gitea:main Mar 23, 2024
26 checks passed
@6543 6543 deleted the enhance/bleve_fuzziness branch March 23, 2024 15:45
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 23, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Mar 23, 2024
@6543 @silverwind
Determine fuzziness of bleve indexer by keyword length (go-gitea#29706)
778f3db 
also bleve did match on fuzzy search and the other way around. this also fix that bug.
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 23, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into fontsize
4412eee 
* origin/main:
  Replace all simple inline styles with tailwind (go-gitea#30032)
  Migrate font-weight helpers to tailwind (go-gitea#30027)
  Remove jQuery from the issue "go to" button (go-gitea#30028)
  Determine fuzziness of bleve indexer by keyword length (go-gitea#29706)
  Escape paths for find file correctly (go-gitea#30026)
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 24, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
207fc43 
* giteaofficial/main: (28 commits)
  Enable a few stylelint rules (go-gitea#30038)
  Remove remaining jQuery .css code (go-gitea#30015)
  Respect DEFAULT_ORG_MEMBER_VISIBLE setting when adding creator to org (go-gitea#30013)
  Remove jQuery `.attr` from the common global functions (go-gitea#30023)
  Migrate font-size helpers to tailwind (go-gitea#30029)
  Replace all simple inline styles with tailwind (go-gitea#30032)
  Migrate font-weight helpers to tailwind (go-gitea#30027)
  Remove jQuery from the issue "go to" button (go-gitea#30028)
  Determine fuzziness of bleve indexer by keyword length (go-gitea#29706)
  Escape paths for find file correctly (go-gitea#30026)
  Remove jQuery `.attr` from the diff page (go-gitea#30021)
  Remove jQuery `.attr` from the repository settings (go-gitea#30018)
  Remove jQuery `.attr` from the image diff again (go-gitea#30022)
  Introduce `.secondary-nav` and handle `.page-content` spacing universally (go-gitea#29982)
  Remove jQuery `.attr` from the branch/tag selector (go-gitea#30010)
  Remove jQuery `.attr` from the commit graph (go-gitea#30006)
  Remove jQuery from the citation modal (except fomantic) (go-gitea#30008)
  Remove jQuery `.attr` from the project page (go-gitea#30004)
  Fix incorrect tailwind migration (go-gitea#30007)
  Enforce trailing comma in JS on multiline (go-gitea#30002)
  ...
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 24, 2024
@zjjhot
Revert "Determine fuzziness of bleve indexer by keyword length (go-gi…
251d2f2 
…tea#29706)"

This reverts commit b9c57fb.
@lng2020 lng2020 mentioned this pull request Apr 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@denyskon denyskon denyskon approved these changes

@delvh delvh delvh approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@6543 @KN4CK3R @lunny @silverwind @denyskon @delvh @GiteaBot