Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose fuzzy search for issues/pulls #29701

Merged
merged 21 commits into from Apr 18, 2024
Merged

Expose fuzzy search for issues/pulls #29701

merged 21 commits into from Apr 18, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 10, 2024 •
edited

close #29685

@6543 6543 added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Mar 10, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 10, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 10, 2024
@6543 6543 added the topic/ui Change the appearance of the Gitea UI label Mar 10, 2024
@6543 6543 added this to the 1.23.0 milestone Mar 10, 2024
This was referenced Mar 10, 2024
Closed
Closed
@6543

This comment was marked as resolved.

Sign in to view
@6543 6543 force-pushed the ui-for-fuzzy-issue-search branch from 1f412a9 to 8ec241c Compare March 11, 2024 13:14
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2024
@6543 6543 force-pushed the ui-for-fuzzy-issue-search branch from 8ec241c to fb11ae4 Compare March 11, 2024 13:20
@6543 6543 mentioned this pull request Mar 12, 2024
Merged
@6543 6543 force-pushed the ui-for-fuzzy-issue-search branch from 2c75415 to 569fbdd Compare March 15, 2024 22:48
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 15, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Mar 15, 2024
@6543 6543 changed the title [Blocked] Expose fuzzy search for issues/pulls Expose fuzzy search for issues/pulls Mar 15, 2024
@6543 6543 marked this pull request as ready for review March 15, 2024 22:49
@silverwind
Copy link
Member

Screenshots?

@6543
Copy link
Member Author

6543 commented Mar 16, 2024

I looks like other fuzzy search boxes ... but i can provide some

@silverwind
Copy link
Member

silverwind commented Mar 16, 2024 •
edited

I guess I will test the branch anyways, but it's always good to have some description and screenshots in PR title, otherwise your PRs will be more likely be ignored by reviewers 😆.

@silverwind
Copy link
Member

Oh, and fix the conflict first please.

@6543
Copy link
Member Author

6543 commented Mar 23, 2024 •
edited

Yes but things against that idea:

  • most indexers (the backemd(s) we depend on) have an option to tuggle fuzzines (meilisearch would be the exeption and do support it)
  • it would be a breaking change as now fizzines is disabled by default then it is enabled by default
  • we need an UX concept that explains that feature to the users

So blocking is the first one ... second is just anojing users

@denyskon
Copy link
Member

I'd say do it. We need to stay consistent. Ideally via shared template. I think there is one already with search box + dropdown.

Yes, there should be a "shared/search/combo_fuzzy"

@silverwind
Copy link
Member

silverwind commented Mar 23, 2024 •
edited

we need an UX concept that explains that feature to the users

I disagree. Google also does not explain their search syntax on the UI. It's just something people learn over time.

@6543
Copy link
Member Author

6543 commented Mar 23, 2024

Well i think we can agree that we disagree in this regards, but that should not hold back the current state just the future paning for the search boxes ... ps: i want more opinions this regards anyway and will go with whatever most can work best with

@6543
Copy link
Member Author

6543 commented Mar 23, 2024

@silverwind I try to enable it for repo-issue-search too ... but just discovered we have a completly different search infrastructure for that 😵‍💫

I'll create an issue but I think this NEEDS a refactor :)

@silverwind
Copy link
Member

silverwind commented Mar 23, 2024 •
edited

Oh, I thought this was just the matter of adding the dropdown. I guess the backend side must be really messy 😆.

In any case, my approval stands but I'm of the opinion that we should move this to "quoted stynax" for exact search and remove all the dropdowns.

@6543
Copy link
Member Author

6543 commented Mar 23, 2024

@denyskon wana be secomd reviewer?

@denyskon
Copy link
Member

I'll check, but not today 😅

@lunny lunny added type/enhancement An improvement of existing functionality and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Apr 17, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 17, 2024
@6543 6543 enabled auto-merge (squash) April 17, 2024 23:50
@6543 6543 merged commit be5be0a into go-gitea:main Apr 18, 2024
26 checks passed
@6543 6543 deleted the ui-for-fuzzy-issue-search branch April 18, 2024 03:08
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 18, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
2f62aa4 
* giteaofficial/main:
  Add an api test for updating user (go-gitea#30539)
  [skip ci] Updated translations via Crowdin
  Expose fuzzy search for issues/pulls (go-gitea#29701)
  Allow everyone to read or write a wiki by a repo unit setting (go-gitea#30495)
  Support nuspec manifest download for nuget packages (go-gitea#28921)
  Fix branch_protection api shows users/teams who has no readAccess (go-gitea#30291)
  Correct locale string rendering (go-gitea#30522)
  Run `go generate` and `go vet` on all packages (go-gitea#30529)
  Fix and tweak pull request commit list (go-gitea#30528)
  Refactor web routes (go-gitea#30519)
  Fix install page checkboxes and dropdown width (go-gitea#30526)

# Conflicts:
#	routers/web/user/home.go
#	templates/user/dashboard/issues.tmpl
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Expose fuzzy search for issues/pulls
7 participants
@6543 @silverwind @sahinakkaya @denyskon @lunny @wxiaoguang @GiteaBot