Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include go files in tailwind processing #29686

Merged
merged 4 commits into from Mar 9, 2024
Merged

Include go files in tailwind processing #29686

merged 4 commits into from Mar 9, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 9, 2024 •
edited

We need to scan .go files for tailwind classes. Does not seem to affect build time much luckily.

Fixes: #29678 (comment)

Verified via rg tw-object-contain public/assets/css/index.css.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 9, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2024
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 9, 2024
@silverwind silverwind mentioned this pull request Mar 9, 2024
Merged
@techknowlogick techknowlogick changed the title Incode go files in tailwind processing Include go files in tailwind processing Mar 9, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 9, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 9, 2024
@denyskon denyskon added type/enhancement An improvement of existing functionality reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2024
@denyskon denyskon added this to the 1.22.0 milestone Mar 9, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2024
@silverwind silverwind merged commit 1695a5a into go-gitea:main Mar 9, 2024
26 checks passed
@silverwind silverwind deleted the gofiles branch March 9, 2024 12:09
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 9, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 9, 2024
@zjjhot
Merge remote-tracking branch 'upstream/main'
4564fbd 
* upstream/main:
  Fix action runner offline label padding (go-gitea#29691)
  Update allowed attachment types (go-gitea#29688)
  Completely style the webkit autofill (go-gitea#29683)
  Include go files in tailwind processing (go-gitea#29686)
  Fix WebHookEditor regression from jQuery removal (go-gitea#29692)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yardenshoham yardenshoham yardenshoham approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silverwind @yardenshoham @denyskon @GiteaBot