Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery from the repo commit functions #29230

Merged
merged 13 commits into from
Feb 22, 2024
Merged

Remove jQuery from the repo commit functions #29230

merged 13 commits into from
Feb 22, 2024

Conversation

yardenshoham
Copy link
Member

@yardenshoham yardenshoham commented Feb 17, 2024 •
edited

  • Switched to plain JavaScript
  • Tested the commit ellipsis button functionality and it works as before
  • Tested the commits statuses tippy functionality and it works as before
  • Tested the last commit loader functionality and it works as before

Demo using JavaScript without jQuery

action
action

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 17, 2024
@yardenshoham
Remove jQuery from repo commit functions
169a9b5 
- Switched to plain JavaScript
- Tested the commit ellipsis button functionality and it works as before
- Tested the commits statuses tippy functionality and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@yardenshoham
Copy link
Member Author

How can I test initRepoCommitLastCommitLoader?

@yardenshoham yardenshoham added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 17, 2024
@delvh
Copy link
Member

delvh commented Feb 17, 2024

Sounds to me like viewing a file and checking if a box pops up showing the last commit that modified this file.
However, what's reactive there?
Isn't that hardcoded in the template code?

@yardenshoham
Copy link
Member Author

I thought so too but I can't seem to trigger it

yardenshoham and others added 3 commits February 18, 2024 07:57
@yardenshoham @silverwind
Update web_src/js/features/repo-commit.js
629da54 
Co-authored-by: silverwind <me@silverwind.io>
@yardenshoham
Merge branch 'main' into repo-commit-jquery
066bc43
@yardenshoham
Use outerHTML
048159f 
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@yardenshoham yardenshoham marked this pull request as ready for review February 19, 2024 20:34
@yardenshoham
Copy link
Member Author

Tested all code, including both POST requests. It's bug-for-bug compatible (the elipsis button not working after replacement)
action

@yardenshoham yardenshoham mentioned this pull request Feb 22, 2024
Merged
delvh
delvh approved these changes Feb 22, 2024
View reviewed changes
web_src/js/features/repo-commit.js Show resolved Hide resolved
web_src/js/features/repo-commit.js Show resolved Hide resolved
@GiteaBot GiteaBot removed the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 22, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 22, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 22, 2024
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 22, 2024
@silverwind
Copy link
Member

silverwind commented Feb 22, 2024 •
edited

Heh, you merged the suggestion too soon apparently, I edited the const in, but it was too late 😆.

@silverwind silverwind enabled auto-merge (squash) February 22, 2024 16:54
@silverwind silverwind merged commit eaede2d into go-gitea:main Feb 22, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 22, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 22, 2024
@yardenshoham yardenshoham deleted the repo-commit-jquery branch February 22, 2024 20:19
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 23, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d1e6961 
* giteaofficial/main:
  Start to migrate from `util.OptionalBool` to `optional.Option[bool]` (go-gitea#29329)
  Add slow SQL query warning (go-gitea#27545)
  Unify organizations header (go-gitea#29248)
  Frontport changelogs of minor releases (go-gitea#29337)
  Support SAML authentication (go-gitea#25165)
  Upgrade to fabric 6 (go-gitea#29334)
  Don't show third-party JS errors in production builds (go-gitea#29303)
  Remove bountysource (go-gitea#29330)
  Remove unnecessary "Str2html" modifier from templates (go-gitea#29319)
  Ignore the linux anchor point to avoid linux migrate failure (go-gitea#29295)
  Remove jQuery from the repo commit functions (go-gitea#29230)
  Remove unnecessary "Safe" modifier from templates (go-gitea#29318)
  Remove jQuery from the image pasting functionality (go-gitea#29324)
  Improve the `issue_comment` workflow trigger event (go-gitea#29277)
  Properly migrate automatic merge GitLab comments (go-gitea#27873)
  Refactor cmd setup and remove deadcode (go-gitea#29313)
  small cache when get user id on interation (go-gitea#29296)
  Discard unread data of `git cat-file` (go-gitea#29297)
  Don't install playwright twice (go-gitea#29302)

# Conflicts:
#	templates/home.tmpl
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yardenshoham @delvh @silverwind @wxiaoguang @GiteaBot