Refactor JWT secret generating & decoding code #29172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
the
modifies/cli
wxiaoguang
removed
the
modifies/cli
wxiaoguang
force-pushed
the
refactor-jwt-secret
branch
from
c2fe4b7
to
8c604b0
Compare
github-actions
bot
added
the
modifies/cli
wxiaoguang
removed
the
modifies/cli
KN4CK3R
approved these changes
Feb 15, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Feb 16, 2024
GiteaBot
added
lgtm/done
github-actions
bot
added
the
modifies/cli
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Old code is not consistent for generating & decoding the JWT secrets. Now, the callers only need to use 2 consistent functions: NewJwtSecretWithBase64 and DecodeJwtSecretBase64 And remove a non-common function Base64FixedDecode from util.go
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Feb 22, 2024
Old code is not consistent for generating & decoding the JWT secrets. Now, the callers only need to use 2 consistent functions: NewJwtSecretWithBase64 and DecodeJwtSecretBase64 And remove a non-common function Base64FixedDecode from util.go
lunny
pushed a commit
that referenced
this pull request
Feb 22, 2024
|
Automatically locked because of our CONTRIBUTING guidelines |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code is not consistent for generating & decoding the JWT secrets.
Now, the callers only need to use 2 consistent functions: NewJwtSecretWithBase64 and DecodeJwtSecretBase64
And remove a non-common function Base64FixedDecode from util.go