Capitalization discarded on push-to-create

[RGBCube]

Description

I have enabled repository.ENABLE_PUSH_CREATE_USER and created a repo after pushing, my remotes are:

Test on  master took 2s
❯ git remote --verbose

origin  ssh://forgejo@rgbcu.be:2222/RGBCube/TestTwo (fetch)
origin  ssh://forgejo@rgbcu.be:2222/RGBCube/TestTwo (push)

But the repo created on my instance is named testtwo. Somewhere Gitea is lowercasing the repo name for case insensitiveness which is nice, but I'd like it to be preserved when push-to-create-ing for the first time.

Gitea Version

1.21.5

Can you reproduce the bug on the Gitea demo site?

Yes

Screenshots

How are you running Gitea?

NixOS module, irrelevant.

Database

PostgreSQL

[yardenshoham]

I tried reproducing but it looks ok to me.

[jolheiser]

My guess is it's specific to SSH:

gitea/cmd/serv.go

Lines 219 to 228 in 5c0fc90

	// LowerCase and trim the repoPath as that's how they are stored.
	repoPath = strings.ToLower(strings.TrimSpace(repoPath))
	rr := strings.SplitN(repoPath, "/", 2)
	if len(rr) != 2 {
	return fail(ctx, "Invalid repository path", "Invalid repository path: %v", repoPath)
	}
	username := strings.ToLower(rr[0])
	reponame := strings.ToLower(strings.TrimSuffix(rr[1], ".git"))

[RGBCube]

My guess is it's specific to SSH:

gitea/cmd/serv.go

Lines 219 to 228 in 5c0fc90

	// LowerCase and trim the repoPath as that's how they are stored.
	repoPath = strings.ToLower(strings.TrimSpace(repoPath))
	rr := strings.SplitN(repoPath, "/", 2)
	if len(rr) != 2 {
	return fail(ctx, "Invalid repository path", "Invalid repository path: %v", repoPath)
	}
	username := strings.ToLower(rr[0])
	reponame := strings.ToLower(strings.TrimSuffix(rr[1], ".git"))

Yup, I use SSH authentication for this

[techknowlogick]

@RGBCube is it the opensshd ssh implementation or the built-in to the binary ssh server you are using? The issue would likely apply to both, but just in case it doesn't this will help debug/fix. Thanks for the report :)

[lunny]

Line 227 and line 228, they should not be lowercase.

[lunny]

I tried reproducing but it looks ok to me.

You are using http protocol. User can try SSH protocol.

[RGBCube]

@RGBCube is it the opensshd ssh implementation or the built-in to the binary ssh server you are using? The issue would likely apply to both, but just in case it doesn't this will help debug/fix. Thanks for the report :)

I'm using sshd at the moment (don't have the BUILTIN_SSH_SERVER option enabled)

[lunny]

The code affected both opensshd and builtin ssh server.

[github-actions]

Automatically locked because of our CONTRIBUTING guidelines