Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli.HelpFlag = nil can be used now when update urfave/cli to v2.26.0 #28444

Closed
successgo opened this issue Dec 12, 2023 · 1 comment · Fixed by #28482
Closed

cli.HelpFlag = nil can be used now when update urfave/cli to v2.26.0 #28444

successgo opened this issue Dec 12, 2023 · 1 comment · Fixed by #28482
Labels
issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea
Milestone
1.22.0

Comments

@successgo
Copy link
Contributor

successgo commented Dec 12, 2023 •
edited

Description

In fact, it's not a bug but rather a TODO that needs attention. I've noticed a TODO at cmd/main.go:L53. Fortunately, the related issue on urfave/cli has been resolved in version v2.26.0. Therefore, it should be safe for us to update the version and comment out the TODO.

The issue was tracked here: urfave/cli/issues/1794, and the fix is included in the release: v2.26.0.

If you find this proposal suitable, I'll proceed with a minor fix.

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Actually I'm not running Gitea.

Database

None
@lunny lunny added issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea and removed type/bug labels Dec 13, 2023
@wxiaoguang wxiaoguang mentioned this issue Dec 15, 2023
Merged
@wxiaoguang
Copy link
Contributor

Thank you for your report.

It doesn't seem a easy work to propose a "minor fix", because it has a long story .....

My decision is to just remove that code. -> Improve CLI code #28482

@lunny lunny added this to the 1.22.0 milestone Dec 15, 2023
lunny pushed a commit that referenced this issue Dec 15, 2023
@wxiaoguang
Improve CLI code and descriptions (#28482)
047c69b 
* Close #28444 
* Actually, it doesn't need to use that trick because it looks like it
is not necessary, no user really needs it
* Remove the hidden (legacy) "doctor" subcommand and update documents
* Fix "actions" usage


![image](https://github.com/go-gitea/gitea/assets/2114189/3c2b34a7-4f92-4a6c-96fd-9505e413d4ec)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@wxiaoguang @fuxiaohei
Improve CLI code and descriptions (go-gitea#28482)
d4adcfe 
* Close go-gitea#28444 
* Actually, it doesn't need to use that trick because it looks like it
is not necessary, no user really needs it
* Remove the hidden (legacy) "doctor" subcommand and update documents
* Fix "actions" usage


![image](https://github.com/go-gitea/gitea/assets/2114189/3c2b34a7-4f92-4a6c-96fd-9505e413d4ec)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@wxiaoguang @silverwind
Improve CLI code and descriptions (go-gitea#28482)
55c77a3 
* Close go-gitea#28444 
* Actually, it doesn't need to use that trick because it looks like it
is not necessary, no user really needs it
* Remove the hidden (legacy) "doctor" subcommand and update documents
* Fix "actions" usage


![image](https://github.com/go-gitea/gitea/assets/2114189/3c2b34a7-4f92-4a6c-96fd-9505e413d4ec)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea
Projects
None yet
Milestone
1.22.0
Development

Successfully merging a pull request may close this issue.

Improve CLI code and descriptions wxiaoguang/gitea
3 participants
@lunny @wxiaoguang @successgo