Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve doctor cli behavior #28422

Merged
merged 2 commits into from Dec 11, 2023
Merged

Improve doctor cli behavior #28422

merged 2 commits into from Dec 11, 2023

Conversation

wxiaoguang
Copy link
Contributor

  1. Do not sort the "checks" slice again and again when "Register", it just wastes CPU when the Gitea instance runs
  2. If a check doesn't exist, tell the end user
  3. Add some tests

@wxiaoguang wxiaoguang added type/enhancement An improvement of existing functionality backport/v1.21 This PR should be backported to Gitea 1.21 labels Dec 11, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Dec 11, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2023
@github-actions github-actions bot added the modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin label Dec 11, 2023
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 11, 2023
@lunny lunny enabled auto-merge (squash) December 11, 2023 13:52
@lunny lunny merged commit f2a309e into go-gitea:main Dec 11, 2023
25 checks passed
@GiteaBot GiteaBot mentioned this pull request Dec 11, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 11, 2023
@wxiaoguang @GiteaBot
Improve doctor cli behavior (go-gitea#28422)
dbec223 
1. Do not sort the "checks" slice again and again when "Register", it
just wastes CPU when the Gitea instance runs
2. If a check doesn't exist, tell the end user
3. Add some tests
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Dec 11, 2023
@wxiaoguang wxiaoguang deleted the fix-doctor-cli branch December 11, 2023 16:13
wxiaoguang added a commit that referenced this pull request Dec 11, 2023
@GiteaBot @wxiaoguang
Improve doctor cli behavior (#28422) (#28424)
1ec622d 
Backport #28422 by wxiaoguang

1. Do not sort the "checks" slice again and again when "Register", it
just wastes CPU when the Gitea instance runs
2. If a check doesn't exist, tell the end user
3. Add some tests

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 12, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
de9f6d8 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Let `curl` write the content to file (go-gitea#28427)
  Improve doctor cli behavior (go-gitea#28422)
  Second part of refactor `db.Find` (go-gitea#28194)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@wxiaoguang @fuxiaohei
Improve doctor cli behavior (go-gitea#28422)
4965495 
1. Do not sort the "checks" slice again and again when "Register", it
just wastes CPU when the Gitea instance runs
2. If a check doesn't exist, tell the end user
3. Add some tests
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@wxiaoguang @silverwind
Improve doctor cli behavior (go-gitea#28422)
28fd4e8 
1. Do not sort the "checks" slice again and again when "Register", it
just wastes CPU when the Gitea instance runs
2. If a check doesn't exist, tell the end user
3. Add some tests
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wxiaoguang @lunny @delvh @GiteaBot