Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment API paths #2813

Merged
merged 2 commits into from Nov 20, 2017
Merged

Fix comment API paths #2813

merged 2 commits into from Nov 20, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Nov 1, 2017

Corrects the following comment API routes

  • PATCH /:owner/:repo/issues/:index/comments/:id -> PATCH /:owner/:repo/issues/comments/:id
  • DELETE /:owner/:repo/issues/:index/comments/:id -> DELETE /:owner/:repo/issues/comments/:id

The previous routes ignored the :index parameter, and were in conflict with the Github API. The previous route are marked as deprecated, but have not been removed.

@lunny lunny added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Nov 1, 2017
@lunny lunny added this to the 1.4.0 milestone Nov 1, 2017
@lunny lunny added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Nov 1, 2017
@lafriks
Copy link
Member

lafriks commented Nov 1, 2017

Can we create new v3 API route group for all these breaking changes?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 1, 2017
@ethantkoenig
Copy link
Member Author

@lafriks IMO, that seems like overkill. I doubt that fixing a few broken routes will cause much disruption.

@lafriks
Copy link
Member

lafriks commented Nov 1, 2017

If we are sure no tool is using it I'm ok with that

@ethantkoenig
Copy link
Member Author

@lafriks I'm not aware of any such tool, but of course I can't guarantee that no such tool exists.

@codecov-io
Copy link

codecov-io commented Nov 1, 2017

Codecov Report

Merging #2813 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2813   +/-   ##
=======================================
  Coverage   27.24%   27.24%           
=======================================
  Files          89       89           
  Lines       17640    17640           
=======================================
  Hits         4806     4806           
  Misses      12146    12146           
  Partials      688      688

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876bafb...492ff2f. Read the comment docs.

@bkcsoft
Copy link
Member

bkcsoft commented Nov 1, 2017

Well, any way to know if it'll break things is to do it and see if anyone complains :trollface:

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 1, 2017
@ethantkoenig
Copy link
Member Author

@lafriks Instead of removing the old, incorrect routes, I've marked them as deprecated. This PR is no longer breaking.

@lafriks
Copy link
Member

lafriks commented Nov 19, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 19, 2017
@lunny lunny removed the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Nov 20, 2017
@lunny lunny merged commit c3b6383 into go-gitea:master Nov 20, 2017
@ethantkoenig ethantkoenig deleted the fix/comment_api branch December 18, 2017 06:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants