Fix Git LFS object/repo link storage in database and small refactoring #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
added
backport/v1.2
type/bug
issue/critical
lafriks
force-pushed
the
fix/lfs_object_right_check
branch
from
b8bf4f9
to
395f4a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2803 +/- ##
==========================================
+ Coverage 26.85% 26.85% +<.01%
==========================================
Files 89 89
Lines 17601 17600 -1
==========================================
Hits 4727 4727
+ Misses 12188 12187 -1
Partials 686 686
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
|
LGTM |
tboerger
added
lgtm/need 1
sapk
approved these changes
Oct 30, 2017
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if same file is stored in multiple repositories only link between first LFS object and repository id is saved in gitea database this way if user has access to only other repositories it is not possible for him to fetch such files. This PR fixes that all LFS object and repository links are stored correctly.
Also if deleting first repository (that only has link between LFS object and repo saved) file from disk will be removed even if that is also used in other repositories so this can lead to serious data loss.
Fixes only partly #2796 - new links will be saved correctly. For previously uploaded LFS objects there needs to be created migration but that can be done in other PR.