Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment-to-ini flag parsing #27914

Merged
merged 3 commits into from Nov 6, 2023
Merged

Conversation

fashberg
Copy link
Contributor

@fashberg fashberg commented Nov 5, 2023

This Fixes #27913

This commit updates environment-to-ini to be compatible with update urfave/cli/v2

Doc: https://cli.urfave.org/v2/examples/combining-short-options/

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 5, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 5, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 5, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 5, 2023
@wxiaoguang wxiaoguang added the backport/v1.21 This PR should be backported to Gitea 1.21 label Nov 5, 2023
@wxiaoguang wxiaoguang enabled auto-merge (squash) November 5, 2023 23:26
@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 5, 2023
@delvh delvh changed the title Fixing #27913, environment-to-ini Update environment-to-ini flag parsing Nov 5, 2023
@silverwind
Copy link
Member

Please run make fmt.

auto-merge was automatically disabled November 6, 2023 18:13

Head branch was pushed to by a user without write access

@silverwind silverwind merged commit c823af2 into go-gitea:main Nov 6, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Nov 6, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 6, 2023
This Fixes go-gitea#27913 

This commit updates `environment-to-ini` to be compatible with update
urfave/cli/v2

Doc: <https://cli.urfave.org/v2/examples/combining-short-options/>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 6, 2023
silverwind pushed a commit that referenced this pull request Nov 6, 2023
Backport #27914 by @fashberg

This Fixes #27913 

This commit updates `environment-to-ini` to be compatible with update
urfave/cli/v2

Doc: <https://cli.urfave.org/v2/examples/combining-short-options/>

Co-authored-by: Folke <folke@ashberg.de>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 7, 2023
* upstream/main:
  Update JS dependencies (go-gitea#27922)
  Update environment-to-ini flag parsing (go-gitea#27914)
  Add `--no-root` to `update-py` (go-gitea#27937)
  Remove `known issue` section in Gitea Actions Doc (go-gitea#27930)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
This Fixes go-gitea#27913 

This commit updates `environment-to-ini` to be compatible with update
urfave/cli/v2

Doc: <https://cli.urfave.org/v2/examples/combining-short-options/>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

environment-to-ini lost short-options in 1.21 and k8s helm-chart installation brakes
6 participants