Add dingtalk webhook #2777
Merged
Add dingtalk webhook #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/feature
lunny
force-pushed
the
lunny/webhook_ding_talk
branch
from
024291a
to
f33e2e3
Compare
ethantkoenig
suggested changes
Oct 25, 2017
models/webhook_dingtalk.go
Outdated
| // for each commit, generate attachment text | ||
| for i, commit := range p.Commits { | ||
| text += fmt.Sprintf("[%s](%s) %s - %s", commit.ID[:7], commit.URL, | ||
| strings.TrimRight(commit.Message, "\r\n"), commit.Author.Name) |
There was a problem hiding this comment.
commit.Author may be nil (see #2771)
models/webhook_dingtalk.go
Outdated
| MsgType: "actionCard", | ||
| ActionCard: dingtalk.ActionCard{ | ||
| Text: title, | ||
| Title: text, |
There was a problem hiding this comment.
Should title and text be reversed?
models/webhook.go
Outdated
| case DING_TALK: | ||
| payloader, err = GetDingtalkPayload(p, event, w.Meta) | ||
| if err != nil { | ||
| return fmt.Errorf("GetDiscordPayload: %v", err) |
models/webhook_dingtalk.go
Outdated
|
|
||
| type ( | ||
|
|
||
| // DingtalkPayload represents |
models/webhook_dingtalk.go
Outdated
| MsgType: "actionCard", | ||
| ActionCard: dingtalk.ActionCard{ | ||
| Text: title, | ||
| Title: text, |
There was a problem hiding this comment.
Should title and text be reversed?
lunny
force-pushed
the
lunny/webhook_ding_talk
branch
from
f33e2e3
to
979991f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2777 +/- ##
==========================================
- Coverage 27.23% 26.99% -0.25%
==========================================
Files 89 90 +1
Lines 17648 17806 +158
==========================================
Hits 4806 4806
- Misses 12154 12312 +158
Partials 688 688
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
|
@ethantkoenig done. |
|
This is ready to review for v1.4 |
|
LGTM |
tboerger
added
lgtm/need 1
ethantkoenig
approved these changes
Nov 21, 2017
|
LGTM |
tboerger
added
lgtm/done
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.