Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label render containing invalid HTML #27752

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Fix label render containing invalid HTML #27752

merged 2 commits into from
Oct 23, 2023

Conversation

earl-warren
Copy link
Contributor

  • The label HTML contained a quote that wasn't being closed.

Refs: https://codeberg.org/forgejo/forgejo/pulls/1651

(cherry picked from commit e2bc2c9a1fff482c49dbeb3a51e4e1c698bf506c)

@Gusted @earl-warren
Fix label render containing invalid HTML
5fb6454 
- The label HTML contained a quote that wasn't being closed.

Refs: https://codeberg.org/forgejo/forgejo/pulls/1651

(cherry picked from commit e2bc2c9a1fff482c49dbeb3a51e4e1c698bf506c)
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2023
@denyskon denyskon added type/bug lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. backport/v1.21 This PR should be backported to Gitea 1.21 and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 23, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2023
@silverwind silverwind added the backport/v1.20 This PR should be backported to Gitea 1.20 label Oct 23, 2023
@silverwind
Copy link
Member

silverwind commented Oct 23, 2023 •
edited

Came from sometimes before #24417 so applies to 1.20 as well.

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 23, 2023
@silverwind silverwind enabled auto-merge (squash) October 23, 2023 18:29
@denyskon denyskon added the giteabot/update-branch Hint for the bot that it should update a PR with the latest state on main label Oct 23, 2023
@GiteaBot GiteaBot removed the giteabot/update-branch Hint for the bot that it should update a PR with the latest state on main label Oct 23, 2023
@wxiaoguang
Copy link
Contributor

Seems to have come from #24417.

No, it's not. 24417 is only a copy&paste refactoring.

The incorrect quote is from #22585

@silverwind silverwind merged commit 6352114 into go-gitea:main Oct 23, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 23, 2023
@GiteaBot GiteaBot mentioned this pull request Oct 23, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 23, 2023
@earl-warren @Gusted @GiteaBot
Fix label render containing invalid HTML (go-gitea#27752)
aaa5707 
- The label HTML contained a quote that wasn't being closed.

Refs: https://codeberg.org/forgejo/forgejo/pulls/1651

(cherry picked from commit e2bc2c9a1fff482c49dbeb3a51e4e1c698bf506c)

Co-authored-by: Gusted <postmaster@gusted.xyz>
@GiteaBot GiteaBot mentioned this pull request Oct 23, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 23, 2023
@earl-warren @Gusted @GiteaBot
Fix label render containing invalid HTML (go-gitea#27752)
4e71d32 
- The label HTML contained a quote that wasn't being closed.

Refs: https://codeberg.org/forgejo/forgejo/pulls/1651

(cherry picked from commit e2bc2c9a1fff482c49dbeb3a51e4e1c698bf506c)

Co-authored-by: Gusted <postmaster@gusted.xyz>
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 23, 2023
lunny pushed a commit that referenced this pull request Oct 24, 2023
@GiteaBot @earl-warren @Gusted
Fix label render containing invalid HTML (#27752) (#27762)
cb9e10f 
Backport #27752 by @earl-warren

- The label HTML contained a quote that wasn't being closed.

Refs: https://codeberg.org/forgejo/forgejo/pulls/1651

(cherry picked from commit e2bc2c9a1fff482c49dbeb3a51e4e1c698bf506c)

Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com>
Co-authored-by: Gusted <postmaster@gusted.xyz>
lunny pushed a commit that referenced this pull request Oct 24, 2023
@GiteaBot @earl-warren @Gusted
Fix label render containing invalid HTML (#27752) (#27761)
63512cd 
Backport #27752 by @earl-warren

- The label HTML contained a quote that wasn't being closed.

Refs: https://codeberg.org/forgejo/forgejo/pulls/1651

(cherry picked from commit e2bc2c9a1fff482c49dbeb3a51e4e1c698bf506c)

Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com>
Co-authored-by: Gusted <postmaster@gusted.xyz>
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.20. @earl-warren, please send one manually. 🍵

go run ./contrib/backport 27752
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Oct 24, 2023
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.21. @earl-warren, please send one manually. 🍵

go run ./contrib/backport 27752
...  // fix git conflicts if any
go run ./contrib/backport --continue

zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 24, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
356b2f4 
* giteaofficial/main:
  Do not force creation of _cargo-index repo on publish (go-gitea#27266)
  Upgrade to golangci-lint@v1.55.0 (go-gitea#27756)
  Fix incorrect "tab" parameter for repo search sub-template (go-gitea#27755)
  Fix label render containing invalid HTML (go-gitea#27752)
  Fix duplicate project board when hitting `enter` key (go-gitea#27746)
  Fix `link-action` redirect network error (go-gitea#27734)
@silverwind silverwind mentioned this pull request Oct 24, 2023
Open
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@earl-warren @Gusted @fuxiaohei
Fix label render containing invalid HTML (go-gitea#27752)
f0031eb 
- The label HTML contained a quote that wasn't being closed.

Refs: https://codeberg.org/forgejo/forgejo/pulls/1651

(cherry picked from commit e2bc2c9a1fff482c49dbeb3a51e4e1c698bf506c)

Co-authored-by: Gusted <postmaster@gusted.xyz>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 22, 2024
@lunny lunny added the backport/done All backports for this PR have been created label Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@denyskon denyskon denyskon approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@earl-warren @silverwind @wxiaoguang @GiteaBot @denyskon @delvh @lunny @Gusted