Math blocks can't be directly preceded or followed by alphanumeric character #27605
Assignees
Labels
Comments
nschloe
changed the title
nschloe
changed the title
|
I managed to reproduce this bug locally, could i be assigned to this issue? |
jmlt2002
added a commit
to jmlt2002/gitea
that referenced
this issue
Mar 28, 2024
… characters Fixes issue go-gitea#27605. This bug happened because of the changes introduced in PR go-gitea#21171. Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt>
jmlt2002
added a commit
to jmlt2002/gitea
that referenced
this issue
Mar 28, 2024
… characters Fixes issue go-gitea#27605, changed tests to account for these changes. This bug happened because of the changes introduced in PR go-gitea#21171. Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt>
jmlt2002
added a commit
to jmlt2002/gitea
that referenced
this issue
Mar 28, 2024
… alphanumerical characters Inline math blocks couldn't be preceeded or succeeded by alphanumerical characters due to changes introduced in PR go-gitea#21171. Removed the condition that caused this (precedingCharacter) and added a new if statement that checks if a specific '$' was escaped using '\'. Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt>
jmlt2002
added a commit
to jmlt2002/gitea
that referenced
this issue
Mar 29, 2024
… alphanumerical characters Inline math blocks couldn't be preceeded or succeeded by alphanumerical characters due to changes introduced in PR go-gitea#21171. Removed the condition that caused this (precedingCharacter) and added a new if statement that checks if a specific '$' was escaped using '\'. Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt>
jmlt2002
added a commit
to jmlt2002/gitea
that referenced
this issue
Mar 29, 2024
… alphanumerical characters Inline math blocks couldn't be preceeded or succeeded by alphanumerical characters due to changes introduced in PR go-gitea#21171. Removed the condition that caused this (precedingCharacter) and added a new if statement that checks if a specific '$' was escaped using '\'. Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt>
GiteaBot
added a commit
to GiteaBot/gitea
that referenced
this issue
Apr 2, 2024
…by alphanumerical characters (go-gitea#30175) - Inline math blocks couldn't be preceeded or succeeded by alphanumerical characters due to changes introduced in PR go-gitea#21171. Removed the condition that caused this (precedingCharacter condition) and added a new exit condition of the for-loop that checks if a specific '$' was escaped using '\' so that the math expression can be rendered as intended. - Additionally this PR fixes another bug where math blocks of the type '$xyz$abc$' where the dollar sign was not escaped by the user, generated an error (shown in the screenshots below) - Altered the tests to accomodate for the changes Former behaviour (from try.gitea.io):  Fixed behaviour (from my local build):  (Edit) Source code for the README.md file: ``` $x$ -$x$ $x$- a$xa$ $xa$a 1$xb$ $xb$1 $a a$b b$ a$b $a a$b b$ $a a\$b b$ ``` --------- Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt> Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot
added a commit
to GiteaBot/gitea
that referenced
this issue
Apr 2, 2024
…by alphanumerical characters (go-gitea#30175) - Inline math blocks couldn't be preceeded or succeeded by alphanumerical characters due to changes introduced in PR go-gitea#21171. Removed the condition that caused this (precedingCharacter condition) and added a new exit condition of the for-loop that checks if a specific '$' was escaped using '\' so that the math expression can be rendered as intended. - Additionally this PR fixes another bug where math blocks of the type '$xyz$abc$' where the dollar sign was not escaped by the user, generated an error (shown in the screenshots below) - Altered the tests to accomodate for the changes Former behaviour (from try.gitea.io):  Fixed behaviour (from my local build):  (Edit) Source code for the README.md file: ``` $x$ -$x$ $x$- a$xa$ $xa$a 1$xb$ $xb$1 $a a$b b$ a$b $a a$b b$ $a a\$b b$ ``` --------- Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt> Co-authored-by: Giteabot <teabot@gitea.io>
HenriquerPimentel
pushed a commit
to HenriquerPimentel/gitea
that referenced
this issue
Apr 2, 2024
…by alphanumerical characters (go-gitea#30175) - Inline math blocks couldn't be preceeded or succeeded by alphanumerical characters due to changes introduced in PR go-gitea#21171. Removed the condition that caused this (precedingCharacter condition) and added a new exit condition of the for-loop that checks if a specific '$' was escaped using '\' so that the math expression can be rendered as intended. - Additionally this PR fixes another bug where math blocks of the type '$xyz$abc$' where the dollar sign was not escaped by the user, generated an error (shown in the screenshots below) - Altered the tests to accomodate for the changes Former behaviour (from try.gitea.io):  Fixed behaviour (from my local build):  (Edit) Source code for the README.md file: ``` $x$ -$x$ $x$- a$xa$ $xa$a 1$xb$ $xb$1 $a a$b b$ a$b $a a$b b$ $a a\$b b$ ``` --------- Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt> Co-authored-by: Giteabot <teabot@gitea.io>
techknowlogick
pushed a commit
that referenced
this issue
Apr 3, 2024
…numerical characters (#30175) (#30250) Backport #30175 by @jmlt2002 - Inline math blocks couldn't be preceeded or succeeded by alphanumerical characters due to changes introduced in PR #21171. Removed the condition that caused this (precedingCharacter condition) and added a new exit condition of the for-loop that checks if a specific '$' was escaped using '\' so that the math expression can be rendered as intended. - Additionally this PR fixes another bug where math blocks of the type '$xyz$abc$' where the dollar sign was not escaped by the user, generated an error (shown in the screenshots below) - Altered the tests to accomodate for the changes Former behaviour (from try.gitea.io):  Fixed behaviour (from my local build):  (Edit) Source code for the README.md file: ``` $x$ -$x$ $x$- a$xa$ $xa$a 1$xb$ $xb$1 $a a$b b$ a$b $a a$b b$ $a a\$b b$ ``` Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt> Co-authored-by: João Tiago <114936010+jmlt2002@users.noreply.github.com>
techknowlogick
pushed a commit
that referenced
this issue
Apr 3, 2024
…numerical characters (#30175) (#30251) Backport #30175 by @jmlt2002 - Inline math blocks couldn't be preceeded or succeeded by alphanumerical characters due to changes introduced in PR #21171. Removed the condition that caused this (precedingCharacter condition) and added a new exit condition of the for-loop that checks if a specific '$' was escaped using '\' so that the math expression can be rendered as intended. - Additionally this PR fixes another bug where math blocks of the type '$xyz$abc$' where the dollar sign was not escaped by the user, generated an error (shown in the screenshots below) - Altered the tests to accomodate for the changes Former behaviour (from try.gitea.io):  Fixed behaviour (from my local build):  (Edit) Source code for the README.md file: ``` $x$ -$x$ $x$- a$xa$ $xa$a 1$xb$ $xb$1 $a a$b b$ a$b $a a$b b$ $a a\$b b$ ``` Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt> Co-authored-by: João Tiago <114936010+jmlt2002@users.noreply.github.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this issue
Apr 3, 2024
* giteaofficial/main: Refactor "dump" sub-command (go-gitea#30240) Add -u git to docs when using docker exec with root installation (go-gitea#29314) Show 12 lines in markup code preview (go-gitea#30255) Fixes go-gitea#27605: inline math blocks can't be preceeded/followed by alphanumerical characters (go-gitea#30175) Render embedded code preview by permlink in markdown (go-gitea#30234) Fix missing 0 prefix of GPG key id (go-gitea#30245) Fix spacing in issue navbar (go-gitea#30238) Add unique index for project_issue to prevent duplicate data (go-gitea#30190) [skip ci] Updated translations via Crowdin Refactor commit signature parser (go-gitea#30228) Refactor dropzone (go-gitea#30232) Remove scheduled action tasks if the repo is archived (go-gitea#30224) Refactor file view & render (go-gitea#30227) Refactor DeleteInactiveUsers, fix bug and add tests (go-gitea#30206) [skip ci] Updated licenses and gitignores Add `/options/license` and `/options/gitignore` to `.ignore` (go-gitea#30219)
AvengerMoJo
pushed a commit
to AvengerMoJo/gitea
that referenced
this issue
Apr 8, 2024
…by alphanumerical characters (go-gitea#30175) - Inline math blocks couldn't be preceeded or succeeded by alphanumerical characters due to changes introduced in PR go-gitea#21171. Removed the condition that caused this (precedingCharacter condition) and added a new exit condition of the for-loop that checks if a specific '$' was escaped using '\' so that the math expression can be rendered as intended. - Additionally this PR fixes another bug where math blocks of the type '$xyz$abc$' where the dollar sign was not escaped by the user, generated an error (shown in the screenshots below) - Altered the tests to accomodate for the changes Former behaviour (from try.gitea.io):  Fixed behaviour (from my local build):  (Edit) Source code for the README.md file: ``` $x$ -$x$ $x$- a$xa$ $xa$a 1$xb$ $xb$1 $a a$b b$ a$b $a a$b b$ $a a\$b b$ ``` --------- Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt> Co-authored-by: Giteabot <teabot@gitea.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MWE:
Screenshot:
This also concerns the
\(...\)and\[...\]syntax.The text was updated successfully, but these errors were encountered: