Fix build errors on BSD (in BSDMakefile) #27594
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `make build` fails because `||` and `&&` have the same precedence in sh/bash, so the `false` command always evaluated (leading to an error). ``` + which gmake /usr/local/bin/gmake + false *** Failed target: .BEGIN *** Failed command: which "gmake" || printf "Error: GNU Make is required!\n\n" 1>&2 && false *** Error code 1 ``` 2. When `GPREFIX` is set to an empty string with quotation marks, `gmake` mistakenly thinks that it's a file name: ``` gmake: *** empty string invalid as file name. Stop. ```
GiteaBot
added
the
lgtm/need 2
sryze
changed the title
silverwind
added
the
topic/build
GiteaBot
added
lgtm/need 1
silverwind
reviewed
Oct 12, 2023
lng2020
approved these changes
Oct 13, 2023
GiteaBot
added
lgtm/done
techknowlogick
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 13, 2023
1. `make build` fails because `||` and `&&` have the same precedence in sh/bash, so the `false` command always evaluated (leading to an error). ``` + which gmake /usr/local/bin/gmake + false *** Failed target: .BEGIN *** Failed command: which "gmake" || printf "Error: GNU Make is required!\n\n" 1>&2 && false *** Error code 1 ``` 2. When `GPREFIX` is set to an empty string with quotation marks, `gmake` mistakenly thinks that it's a file name: ``` gmake: *** empty string invalid as file name. Stop. ```
GiteaBot
added
backport/done
silverwind
pushed a commit
that referenced
this pull request
Oct 14, 2023
Backport #27594 by @sryze 1. `make build` fails because `||` and `&&` have the same precedence in sh/bash, so the `false` command always evaluated (leading to an error). ``` + which gmake /usr/local/bin/gmake + false *** Failed target: .BEGIN *** Failed command: which "gmake" || printf "Error: GNU Make is required!\n\n" 1>&2 && false *** Error code 1 ``` 2. When `GPREFIX` is set to an empty string with quotation marks, `gmake` mistakenly thinks that it's a file name: ``` gmake: *** empty string invalid as file name. Stop. ``` Co-authored-by: Sergey Zolotarev <sryze@protonmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 16, 2023
* giteaofficial/main: [skip ci] Updated licenses and gitignores Improve retrying index issues (go-gitea#27554) Replace more db.DefaultContext (go-gitea#27628) Fix 404 when there is an internal version of package (go-gitea#27615) [skip ci] Updated translations via Crowdin Add anchor to review types (go-gitea#26894) Update readme to remove drone svg (go-gitea#27624) Change the default branch in the agit docs (go-gitea#27621) Final round of `db.DefaultContext` refactor (go-gitea#27587) Fix permissions for Token DELETE endpoint to match GET and POST (go-gitea#27610) Enhanced auth token / remember me (go-gitea#27606) [skip ci] Updated translations via Crowdin rm outdated docs from some languages (go-gitea#27530) Upgrade go dependencies (go-gitea#27599) Fix build errors on BSD (in BSDMakefile) (go-gitea#27594) Enable shorthands in `declaration-strict-value` linter (go-gitea#27597) [skip ci] Updated translations via Crowdin Make disk clean action a bit more robust (go-gitea#27590)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make buildfails because||and&&have the same precedence in sh/bash, so thefalsecommand always evaluated (leading to an error).When
GPREFIXis set to an empty string with quotation marks,gmakemistakenly thinks that it's a file name:gmake: *** empty string invalid as file name. Stop.