Make disk clean action a bit more robust #27590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
silverwind
added
the
skip-changelog
lunny
approved these changes
Oct 12, 2023
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Oct 12, 2023
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 16, 2023
* giteaofficial/main: [skip ci] Updated licenses and gitignores Improve retrying index issues (go-gitea#27554) Replace more db.DefaultContext (go-gitea#27628) Fix 404 when there is an internal version of package (go-gitea#27615) [skip ci] Updated translations via Crowdin Add anchor to review types (go-gitea#26894) Update readme to remove drone svg (go-gitea#27624) Change the default branch in the agit docs (go-gitea#27621) Final round of `db.DefaultContext` refactor (go-gitea#27587) Fix permissions for Token DELETE endpoint to match GET and POST (go-gitea#27610) Enhanced auth token / remember me (go-gitea#27606) [skip ci] Updated translations via Crowdin rm outdated docs from some languages (go-gitea#27530) Upgrade go dependencies (go-gitea#27599) Fix build errors on BSD (in BSDMakefile) (go-gitea#27594) Enable shorthands in `declaration-strict-value` linter (go-gitea#27597) [skip ci] Updated translations via Crowdin Make disk clean action a bit more robust (go-gitea#27590)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to address this. I think it's good practice to always run
apt-get updatebefore any other apt actions. Also I added|| trueto the removal steps so that it won't fail in the future when a package is not present. Finally I addedDEBIAN_FRONTENDfor good measure.