Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yet another ctx template bug #27417

Merged
merged 4 commits into from Oct 4, 2023
Merged

Fix yet another ctx template bug #27417

merged 4 commits into from Oct 4, 2023

Conversation

delvh
Copy link
Member

@delvh delvh commented Oct 3, 2023 •
edited

Fixes #27416

@delvh delvh added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Oct 3, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 3, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2023
@github-actions github-actions bot added the topic/ui Change the appearance of the Gitea UI label Oct 3, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 3, 2023
@JakobDev
Copy link
Contributor

JakobDev commented Oct 3, 2023

We really need a test that opens the fronted pages and checks if some has a 500 status code

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 3, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2023
@silverwind silverwind enabled auto-merge (squash) October 3, 2023 21:01
@6543 6543 added this to the 1.22.0 milestone Oct 3, 2023
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 4, 2023
auto-merge was automatically disabled October 4, 2023 01:41

Base branch was modified

@techknowlogick techknowlogick enabled auto-merge (squash) October 4, 2023 01:41
@techknowlogick techknowlogick merged commit 112f37c into go-gitea:main Oct 4, 2023
25 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 4, 2023
@delvh @GiteaBot
Fix yet another ctx template bug (go-gitea#27417)
4486428 
Fixes go-gitea#27416
@GiteaBot GiteaBot mentioned this pull request Oct 4, 2023
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 4, 2023
@delvh delvh deleted the more-ctx-template-fixes branch October 4, 2023 06:43
silverwind pushed a commit that referenced this pull request Oct 4, 2023
@GiteaBot @delvh
Fix yet another ctx template bug (#27417) (#27426)
99e2071 
Backport #27417 by @delvh

Fixes #27416

Co-authored-by: delvh <dev.lh@web.de>
silverwind added a commit to silverwind/gitea that referenced this pull request Oct 4, 2023
@silverwind
Merge main, rename to gitea-auto
454e475 
* origin/main:
  When comparing with an non-exist repository, return 404 but 500 (go-gitea#27437)
  Fix pr template (go-gitea#27436)
  Use minimal required version on CI and remove unnecessary services (go-gitea#27429)
  Fix  missing `ctx`  in new_form.tmpl  (go-gitea#27434)
  Use flex-container for repo and org settings (go-gitea#27418)
  Fix yet another `ctx` template bug (go-gitea#27417)
  Add Index to `action.user_id` (go-gitea#27403)
  [skip ci] Updated translations via Crowdin
@silverwind silverwind mentioned this pull request Oct 6, 2023
Closed
delvh added a commit to delvh/gitea that referenced this pull request Oct 6, 2023
@delvh
Revert "Fix yet another ctx template bug (go-gitea#27417) (go-gitea…
9e194f6 
…#27426)"

This reverts commit 99e2071.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Failed to render template "profile_big_avatar"
6 participants
@delvh @JakobDev @silverwind @techknowlogick @GiteaBot @6543