Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update status and code index after changing the default branch #27018

Merged
merged 10 commits into from
Sep 13, 2023
Merged

Update status and code index after changing the default branch #27018

merged 10 commits into from
Sep 13, 2023

Conversation

lng2020
Copy link
Member

@lng2020 lng2020 commented Sep 11, 2023

Fix #26723
Add ChangeDefaultBranch to the notifier interface and implement it in indexerNotifier. So when changing the default branch, indexerNotifier sends a message to the indexer queue to update the index.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 11, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2023
lunny
lunny reviewed Sep 11, 2023
View reviewed changes
modules/indexer/code/git.go Outdated Show resolved Hide resolved
lunny
lunny reviewed Sep 12, 2023
View reviewed changes
modules/indexer/code/git.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 12, 2023
@lunny lunny added type/bug backport/v1.20 This PR should be backported to Gitea 1.20 labels Sep 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 13, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 13, 2023
@lunny lunny enabled auto-merge (squash) September 13, 2023 04:14
@lunny lunny merged commit cda97a7 into go-gitea:main Sep 13, 2023
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 13, 2023
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.20. @lng2020, please send one manually. 🍵

go run ./contrib/backport 27018
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Sep 13, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 13, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8251797 
* giteaofficial/main:
  fix media description render for orgmode (go-gitea#26895)
  Show OpenID Connect and OAuth on signup page (go-gitea#20242)
  Update status and code index after changing the default branch (go-gitea#27018)
  add sparse url in cargo package guide (go-gitea#26937)
  Add missing 404 response to Swagger (go-gitea#27038)
  Fix object storage path handling (go-gitea#27024)
  [skip ci] Updated translations via Crowdin
  bump rootful to 16gb
  setup go in the nightly release pipeline
  Speed up nightly builds (go-gitea#27045)
  Improve repo/user/org search  (go-gitea#27030)
  Use Actuated.dev runner for nightly builds
  update snap package (go-gitea#27021)
  resolve issue with sort icons on admin/users and admin/runners (go-gitea#24360)
@loynoir loynoir mentioned this pull request Sep 13, 2023
Closed
@delvh delvh modified the milestones: 1.22.0, 1.21.0 Sep 13, 2023
@lng2020 lng2020 deleted the fix/update-code-index-after-change-default-branch branch November 7, 2023 07:51
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/manual No power to the bots! Create your backport yourself! backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

conditions that code cannot be searched
6 participants
@lng2020 @GiteaBot @lunny @techknowlogick @wxiaoguang @delvh