Refactor system setting #27000
Merged
Refactor system setting #27000
+411
−507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
Sep 11, 2023
wxiaoguang
force-pushed
the
refactor-setting
branch
3 times, most recently
from
bd80e39 to
6c6c309
Compare
wxiaoguang
force-pushed
the
refactor-setting
branch
from
45025eb to
cd961b7
Compare
wxiaoguang
force-pushed
the
refactor-setting
branch
4 times, most recently
from
850c0e4 to
8014055
Compare
wxiaoguang
force-pushed
the
refactor-setting
branch
from
8014055 to
171af38
Compare
|
Almost ready for review. |
wxiaoguang
force-pushed
the
refactor-setting
branch
from
171af38 to
55f90e3
Compare
wxiaoguang
added
the
type/refactoring
lunny
approved these changes
Sep 25, 2023
GiteaBot
added
lgtm/need 1
# Conflicts: # templates/admin/config.tmpl
wolfogre
approved these changes
Oct 4, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 5, 2023
This PR reduces the complexity of the system setting system. It only needs one line to introduce a new option, and the option can be used anywhere out-of-box. It is still high-performant (and more performant) because the config values are cached in the config system.
GiteaBot
added
backport/done
lunny
pushed a commit
that referenced
this pull request
Oct 5, 2023
Backport #27000 by @wxiaoguang This PR reduces the complexity of the system setting system. It only needs one line to introduce a new option, and the option can be used anywhere out-of-box. It is still high-performant (and more performant) because the config values are cached in the config system.  Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the complexity of the system setting system.
It only needs one line to introduce a new option, and the option can be used anywhere out-of-box.
It is still high-performant (and more performant) because the config values are cached in the config system.