New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INI value with trailing slash causes bugs #26977

Closed

wxiaoguang opened this issue Sep 8, 2023 · 2 comments · Fixed by #26995

Assignees

Labels

Milestone

Contributor

wxiaoguang commented Sep 8, 2023

eg:

[foo]
key = C:\
xxx = yyy

The current code reads: key = C:\xxx = yyy and can't read xxx

The text was updated successfully, but these errors were encountered:

wxiaoguang added this to the 1.21.0 milestone

wxiaoguang self-assigned this

wxiaoguang added the type/bug label

Member

silverwind commented Sep 8, 2023 •

edited

\ at end of line is common on unix shells for line continuation. I'd argue we should encourage quoting all strings anyways. OTOH, I don't see a valid use case for such line continuation in the configs either, so could drop it.

Contributor Author

wxiaoguang commented Sep 8, 2023 •

edited

The problem is , ini package doesn't encode the \ when writing.

So, in code we SetValue("E:\\"), but we can not read the correct value next time. That's why it is a bug.

And I would also agree to drop the especial \ handling rule for ini reading.

wxiaoguang mentioned this issue

Fix INI parsing for value with trailing slash #26995

Merged

KN4CK3R closed this as completed in #26995

KN4CK3R pushed a commit that referenced this issue


          Fix INI parsing for value with trailing slash (#26995)

e7745c9

Fix #26977 (a temp fix)

GiteaBot mentioned this issue

Fix INI parsing for value with trailing slash (#26995) #27001

Merged

GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue


          Fix INI parsing for value with trailing slash (go-gitea#26995)

900441a

Fix go-gitea#26977 (a temp fix)

KN4CK3R pushed a commit that referenced this issue


          Fix INI parsing for value with trailing slash (#26995) (#27001)

da7d7e6

Backport #26995 by @wxiaoguang

Fix #26977 (a temp fix)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.