Expanded minimum RSA Keylength to 3072 #26604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
German Federal Office for Information Security requests in its technical guideline BSI TR-02102-1 RSA Keylength not shorter than 3000bits starting 2024, in the year 2023 3000bits as a recommendation. Gitea should request longer RSA Keys by default in favor of security and drop old clients which do not support shorter keys.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
silverwind
added
the
topic/security
techknowlogick
added
the
pr/breaking
|
CI fails, the test code also needs to be updated accordingly. Would you like to fix them or would you like some maintainers to edit this PR to help? |
pull-request-size
bot
added
size/S
|
Searched again and found way more occurences of 2048 bit RSA. gitea/models/asymkey/ssh_key_test.go Line 31 in a4cfeae |
wxiaoguang
approved these changes
Aug 21, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Aug 21, 2023
GiteaBot
added
lgtm/done
|
CI still fails |
|
Unit test need a refactor. |
puni9869
added
the
lgtm/blocked
|
Honestly dont know what to do. Please help. |
|
No worries,
Please run This is the trace from error |
GiteaBot
removed
the
lgtm/blocked
wxiaoguang
reviewed
Aug 25, 2023
wxiaoguang
added
reviewed/wait-merge
puni9869
approved these changes
Aug 25, 2023
|
🚀 |
|
CI passes. And IMO this is not "breaking", all uploaded/generated keys are not affected, so removed the "breaking" label. Feel free to add the breaking label back if it is really breaking (with detailed breaking description and what users should do to handle the breaking) |
|
Thank both of you! |
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 28, 2023
* giteaofficial/main: Fix bug for ctx usage (go-gitea#26762) Remove some transition related code (go-gitea#26755) Expanded minimum RSA Keylength to 3072 (go-gitea#26604) [skip ci] Updated licenses and gitignores Use docs.gitea.com instead of docs.gitea.io (go-gitea#26739) Adding hint `Archived` to archive label. (go-gitea#26741) # Conflicts: # templates/base/head_navbar.tmpl
silverwind
added
the
pr/breaking
|
I added a missing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
German Federal Office for Information Security requests in its technical guideline BSI TR-02102-1 RSA Keylength not shorter than 3000bits starting 2024, in the year 2023 3000bits as a recommendation. Gitea should request longer RSA Keys by default in favor of security and drop old clients which do not support longer keys.
https://www.bsi.bund.de/SharedDocs/Downloads/DE/BSI/Publikationen/TechnischeRichtlinien/TR02102/BSI-TR-02102.pdf?__blob=publicationFile&v=9 - Page 19, Table 1.2