HTTP 500 while creating users

[KazzmanK]

Description

I tried to create a new user, user visibility was defaulted to private, but after clicking Create user - error 500.
Should it be a 500 error? May be a more user friendly message?
But I set user visibility to "Private", and Public users are indeed disallowed. And there was no "Public" item in visibility dropdown at all.

It looks like UI inconsistency between default dropdown selection and data passed to backend.
If I re-select Private in dropdown, user created without error.

Gitea Version

1.20

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

win service

Database

None

[lunny]

I think this should be fixed by #24867

[KazzmanK]

But this is a new user creation, not updating existing one. Looks more like a UI issue, where wrong item from dropdown select is passed to back.

[stuzer05]

It's fixed

[ovisan]

I am facing the same issue. We have 2 gitea instances deployed (dev and prod) in kubernetes via helm, with the same settings in the helmrelease. In prod i can create a user when the visibility is set to private, but in dev i get 500.

This is the eror line from the pod.

│ gitea 2023/07/28 08:13:31 ...ers/web/auth/auth.go:516:createUserInContext() [E] [64c378ab] CreateUser: visibility Mode not allowed: private