Move public asset files to the proper directory #25907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
added
the
pr/breaking
pull-request-size
bot
added
the
size/L
wxiaoguang
force-pushed
the
move-public-assets
branch
from
6bc6553
to
5c775e8
Compare
|
Good change, thanks. |
wxiaoguang
force-pushed
the
move-public-assets
branch
from
5c775e8
to
456632d
Compare
silverwind
reviewed
Jul 16, 2023
|
There are many references to |
After getting approvals, I will update the documents (including: customization, public/css, public/js, public/img) 1.21 is at the early stage, so I think we have enough time to test this PR after it gets merged. |
|
CI passes. If the code change looks good to reviewers, I will update the documents (including: customization, public/css, public/js, public/img). If there are concerns, let's resolve the concerns first before the documentation work (to save everyone's time) |
delvh
added
the
type/refactoring
delvh
approved these changes
Jul 16, 2023
GiteaBot
added
lgtm/need 1
denyskon
approved these changes
Jul 16, 2023
GiteaBot
added
lgtm/done
wolfogre
approved these changes
Jul 17, 2023
wxiaoguang
added
the
reviewed/wait-merge
silverwind
approved these changes
Jul 18, 2023
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Jul 18, 2023
* main: Refactor "Content" for file uploading (go-gitea#25851) Fix SSPI auth panic (go-gitea#25955) Make pending commit status yellow again (go-gitea#25935) Move public asset files to the proper directory (go-gitea#25907) Disallow dangerous url schemes (go-gitea#25960) Avoid creating directories when loading config (go-gitea#25944) [skip ci] Updated translations via Crowdin
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 20, 2023
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix commit status color on dashboard repolist (go-gitea#25993) Improve profile readme rendering (go-gitea#25988) avoid hard-coding height in language dropdown menu (go-gitea#25986) parseScope with owner/repo always sets owner to zero (go-gitea#25987) Bump github.com/golang-jwt/jwt to v5 (go-gitea#25975) Update path related documents (go-gitea#25417) Update djlint, enable H026 and T027 (go-gitea#25980) [skip ci] Updated translations via Crowdin Show the mismatched ROOT_URL warning on the sign-in page if OAuth2 is enabled (go-gitea#25947) Refactor "Content" for file uploading (go-gitea#25851) Fix SSPI auth panic (go-gitea#25955) Make pending commit status yellow again (go-gitea#25935) Move public asset files to the proper directory (go-gitea#25907) Disallow dangerous url schemes (go-gitea#25960) Avoid creating directories when loading config (go-gitea#25944)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
public/*topublic/assets/*Some old PRs (like #15219) introduced inconsistent directory system.
For example: why the local directory "public" is accessed by
http://site/assets? How to serve the ".well-known" files properly in the public directory?For convention rules, the "public" directory is widely used for the website's root directory. It shouldn't be an exception for Gitea.
So, this PR makes the things consistent:
http://site/assets/foomeans{CustomPath}/public/assets/foo.{CustomPath}/public/.well-knownand{CustomPath}/public/robots.txtcan be used in the future.This PR is also a prerequisite for a clear solution for:
This PR is breaking for users who have custom "public" files (CSS/JS). After getting approvals, I will update the documents.
If you have files in your "custom/public/" folder, please move them to "custom/public/assets/".