Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default value for LocalURL #25426

Merged
merged 4 commits into from
Jun 24, 2023
Merged

Fix default value for LocalURL #25426

merged 4 commits into from
Jun 24, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 21, 2023

Fix #23769

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Jun 21, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 21, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2023
@silverwind
Copy link
Member

Also need to update app.example.ini.

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2023
@lunny
Copy link
Member Author

lunny commented Jun 23, 2023

Also need to update app.example.ini.

Done.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 23, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 24, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 24, 2023
@lunny lunny merged commit 9c62ca5 into go-gitea:main Jun 24, 2023
23 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jun 24, 2023
@lunny lunny deleted the lunny/fix_docs_default_value branch June 24, 2023 03:56
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 24, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

APP_LOCAL_URL default incorrect in docs
4 participants
@lunny @silverwind @wxiaoguang @GiteaBot