Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs from automatically building in Gitpod #23978

Merged
merged 7 commits into from
Apr 7, 2023

Conversation

yardenshoham
Copy link
Member

I couldn't find a way to build the docs without trans-copy and spinning up a dev environment that generates files untracked by git on startup is not a good development experience

I couldn't find a way to build the docs without `trans-copy` and spinning up a dev environment that generates files untracked by git on startup is not a good development experience

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@yardenshoham yardenshoham added this to the 1.20.0 milestone Apr 7, 2023
@yardenshoham yardenshoham added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 7, 2023
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, docs build is rarely useful. We don't need to bloat the gitpod environment with it.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 7, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 7, 2023
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #23978 (05603fb) into main (f521e88) will decrease coverage by 0.10%.
The diff coverage is 31.71%.

❗ Current head 05603fb differs from pull request most recent head e2df284. Consider uploading reports for the commit e2df284 to get more accurate results

@@            Coverage Diff             @@
##             main   #23978      +/-   ##
==========================================
- Coverage   47.14%   47.05%   -0.10%     
==========================================
  Files        1149     1163      +14     
  Lines      151446   153691    +2245     
==========================================
+ Hits        71397    72317     +920     
- Misses      71611    72869    +1258     
- Partials     8438     8505      +67     
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.63% <0.00%> (-0.10%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
... and 65 more

... and 100 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@silverwind silverwind enabled auto-merge (squash) April 7, 2023 19:15
@yardenshoham
Copy link
Member Author

Ping lgtm bot?

@silverwind silverwind merged commit 518d384 into go-gitea:main Apr 7, 2023
@yardenshoham yardenshoham deleted the remove-docs-from-gitpod branch April 7, 2023 19:55
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 7, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants