Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for access in /repositories/:id #2227

Merged
merged 2 commits into from
Jul 30, 2017
Merged

Check for access in /repositories/:id #2227

merged 2 commits into from
Jul 30, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Jul 29, 2017 •
edited

Fix permission-checking bug in API endpoint.

Also added an integration test

@Bwko
Copy link
Member

Bwko commented Jul 29, 2017

LGTM

@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 29, 2017
@lafriks
Copy link
Member

lafriks commented Jul 29, 2017

Please add integration test

@lafriks
Copy link
Member

lafriks commented Jul 30, 2017

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 30, 2017
@lafriks lafriks added this to the 1.2.0 milestone Jul 30, 2017
@lunny lunny merged commit 49df677 into go-gitea:master Jul 30, 2017
@ethantkoenig ethantkoenig deleted the fix/repositories_api branch July 31, 2017 02:24
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ethantkoenig @Bwko @lafriks @lunny @bkcsoft