Fix issue updated_unix bug #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trusted LGTM |
|
LGTM |
lafriks
added
the
lgtm/done
|
@ethantkoenig please force empty push |
|
@ethantkoenig please resolve conflict |
ethantkoenig
force-pushed
the
fix/issue_updated_unix
branch
from
745e118
to
3c0f6d8
Compare
|
make L-G-T-M work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1938.
The
Issue.UpdatedUnixcolumn is set in theBeforeUpdate()method. However, that write had no effect on theupdated_unixcolumn whenupdateIssueCols(..)was called, unless"updated_unix"was explicitly listed as a column to update.This PR:
updateIssueCols(..)to always updateupdated_unix.createComment()to update an issue'supdated_unixcolumn when a comment is added.