Use GhostUser if needed for TrackedTimes #22021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting tracked times out of the db and loading their attributes handle not exist errors in a nicer way. (Also prevent an NPE.) Fix go-gitea#22006 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
outdated/backport/v1.18
|
The tracked time loadAttributes code could be quite expensive and may get a lot of things out of the db repeatedly. This and other places that use this loadAttributes style should really use a local cache. |
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Dec 4, 2022
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Dec 4, 2022
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Dec 4, 2022
Backport go-gitea#22021 When getting tracked times out of the db and loading their attributes handle not exist errors in a nicer way. (Also prevent an NPE.) Fix go-gitea#22006 Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 5, 2022
* giteaofficial/main: Ensure that Chinese punctuation is not ambiguous when locale is Chinese (go-gitea#22019) Use GhostUser if needed for TrackedTimes (go-gitea#22021) Add dumb-init to rootless docker (go-gitea#21775) On tag/branch-exist check, dont panic if repo is nil (go-gitea#21787) Fix ListBranches to handle empty case (go-gitea#21921) fix(web): reduce page jitter on browsers that support overlay scrollbar (go-gitea#21850) [skip ci] Updated licenses and gitignores Do not emit ambiguous character warning on rendered pages (go-gitea#22016)
lafriks
pushed a commit
that referenced
this pull request
Dec 5, 2022
Backport #22021 When getting tracked times out of the db and loading their attributes handle not exist errors in a nicer way. (Also prevent an NPE.) Fix #22006 Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting tracked times out of the db and loading their attributes handle not exist errors in a nicer way. (Also prevent an NPE.)
Fix #22006
Signed-off-by: Andrew Thornton art27@cantab.net