Adjust doctor command format and options #21790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gitea doctor command is a little weird especially since the recreate-table subcommand. This PR changes the doctor command to be an empty subcommand and adds `gitea doctor check` subcommand. In this subcommand the requested checks are provided as an argument rather than as options. The logging is also changed so that the doctor.log is not provided by default - instead that will only be created if you set `--log-file` option. `--verbose` is provided to output this logging to stdout. `gitea convert` is also moved to be a subcommand as `gitea doctor convert`. Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
reviewed
Nov 15, 2022
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
added
the
pr/breaking
lunny
reviewed
Feb 3, 2023
lunny
approved these changes
Feb 6, 2023
GiteaBot
added
lgtm/need 1
|
Need to update version in references. |
|
@zeripath I briefly looked through the PR, and it looks good to me. Could you please change the version numbers and resolve merge conflicts, so we can finally have this merged? |
denyskon
added
issue/needs-feedback
|
I guess @zeripath is currently inactive, but you could raise another PR in place of this one. |
|
There are some problems for this PR:
So I proposed a new one: Improve "gitea doctor" sub-command and fix "help" commands #26072 |
wxiaoguang
added a commit
that referenced
this pull request
Jul 25, 2023
Replace #21790 And close #25965 by the way (it needs a separate fix for 1.20) Major changes: 1. Move "gitea convert" to "gitea doctor conver". The old "gitea doctor" still works as a hidden sub-command (to avoid breaking) 2. Do not write "doctor.log" by default, it's not useful in most cases and causes bugs like 25965 3. Improve documents 4. Fix the "help" commands. Before, the "./gitea doctor" can't show the sub-command help correctly (regression of the last cli/v2 refactoring) After this PR: ``` ./gitea help # show all sub-commands for the app ./gitea doctor # show the sub-commands for the "doctor" ./gitea doctor help # show the sub-commands for the "doctor", as above ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gitea doctor command is a little weird especially since the recreate-table subcommand.
This PR changes the doctor command to be an empty subcommand and adds
gitea doctor checksubcommand.In this subcommand the requested checks are provided as an argument rather than as options. The logging is also changed so that the doctor.log is not provided by default - instead that will only be created if you set
--log-fileoption.--verboseis provided to output this logging to stdout.gitea convertis also moved to be a subcommand asgitea doctor convert.Signed-off-by: Andrew Thornton art27@cantab.net