Add .dockerignore #21753
Merged
Add .dockerignore #21753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfogre
added
the
topic/build
lunny
approved these changes
Nov 10, 2022
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
Nov 10, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 11, 2022
* giteaofficial/main: Revert unrelated changes for SMTP auth (go-gitea#21767) Init git module before database migration (go-gitea#21764) Extract updateSession function to reduce repetition (go-gitea#21735) Fix dashboard ignored system setting cache (go-gitea#21621) Add .dockerignore (go-gitea#21753)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of work that has been done on
.dockerignore:And finally, it has been deleted by #2927.
I think we may have made this a little too complicated. Since we're compiling Gitea in docker, there's a simple rule to write
.dockerignore: if we don't need the files in git commiting, we don't need them in docker building. So why not just copy.gitignoreto.dockerignore?Maybe creating a soft link is more elegant, but I think it may cause unnecessary trouble to the Windows users.