Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wording about keeping PRs up-to-date in CONTRIBUTING.md #21468

Merged
merged 12 commits into from Oct 15, 2022
Merged

Add wording about keeping PRs up-to-date in CONTRIBUTING.md #21468

merged 12 commits into from Oct 15, 2022

Conversation

yardenshoham
Copy link
Member

Following a discord discussion from today I've written the policy explained to me about keeping PRs up-to-date.

@yardenshoham
Add wording about keeping PRs up-to-date in CONTRIBUTING.md
893492f 
Following a discord discussion from today I've written the policy explained to me about keeping PRs up-to-date.

Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
@yardenshoham
Copy link
Member Author

Please make sure what I've written is true

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 15, 2022
@yardenshoham
Break line
16a66f4 
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
@yardenshoham
Fix typo
c789b37 
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
wxiaoguang
wxiaoguang reviewed Oct 15, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 15, 2022
wxiaoguang
wxiaoguang reviewed Oct 15, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
6543
6543 approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thanks!!!

we should long ago have put that in

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 15, 2022
@6543 6543 added the type/docs This PR mainly updates/creates documentation label Oct 15, 2022
6543
6543 reviewed Oct 15, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
6543
6543 reviewed Oct 15, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
6543
6543 reviewed Oct 15, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@yardenshoham yardenshoham mentioned this pull request Oct 15, 2022
Merged
techknowlogick
techknowlogick reviewed Oct 15, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@techknowlogick techknowlogick merged commit 671c609 into go-gitea:main Oct 15, 2022
@yardenshoham yardenshoham deleted the contributing-up-to-date branch October 15, 2022 16:44
@yardenshoham yardenshoham mentioned this pull request Oct 15, 2022
Merged
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yardenshoham @techknowlogick @wxiaoguang @6543 @GiteaBot