Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow improve code quality #21465

Merged
merged 5 commits into from Oct 15, 2022
Merged

Follow improve code quality #21465

merged 5 commits into from Oct 15, 2022

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 15, 2022 •
edited

After some discussion, introduce a new slice brokenArgs to make gitCmd.Run() return errors if any dynamic argument is invalid.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 15, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 15, 2022
@wxiaoguang wxiaoguang mentioned this pull request Oct 15, 2022
Merged
delvh
delvh reviewed Oct 15, 2022
View reviewed changes
modules/git/command.go Outdated Show resolved Hide resolved
delvh
delvh approved these changes Oct 15, 2022
View reviewed changes
modules/git/command.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 15, 2022
@wxiaoguang @delvh
Update modules/git/command.go
ae10111 
Co-authored-by: delvh <dev.lh@web.de>
@6543 6543 merged commit 677af6a into go-gitea:main Oct 15, 2022
@6543 6543 added this to the 1.18.0 milestone Oct 15, 2022
@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 15, 2022
@wxiaoguang wxiaoguang deleted the fix2 branch October 15, 2022 12:23
6543 added a commit that referenced this pull request Oct 15, 2022
@6543 @wxiaoguang
improve code quality (#21464) (#21463)
cd48a00 
Backport #21464 and #21465

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang wxiaoguang mentioned this pull request Oct 15, 2022
Merged
tyroneyeh pushed a commit to tyroneyeh/gitea that referenced this pull request Oct 24, 2022
@6543 @wxiaoguang @tyroneyeh
improve code quality (go-gitea#21464) (go-gitea#21463)
8cb55c1 
Backport go-gitea#21464 and go-gitea#21465

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wxiaoguang @lunny @6543 @delvh @GiteaBot