New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Drone pushing commits with wrong author info #21450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yardenshoham
changed the title
Fix Drone pushing commits with bad author
Fix Drone pushing commits with wrong author info
Oct 14, 2022
techknowlogick
added
type/bug
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
labels
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this PR <3 Drone will fail on yaml refs across pipelines, could you instead hardcode the data instead of the ref?
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Oct 14, 2022
yardenshoham
force-pushed
the
crowdin-ci
branch
from
October 14, 2022 09:02
3a2cd46
to
b7eb803
Compare
yardenshoham
force-pushed
the
crowdin-ci
branch
2 times, most recently
from
October 14, 2022 14:04
963bbaa
to
cba6536
Compare
techknowlogick
approved these changes
Oct 14, 2022
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Oct 14, 2022
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
yardenshoham
force-pushed
the
crowdin-ci
branch
from
October 14, 2022 15:29
cba6536
to
6feaf45
Compare
@techknowlogick can you trigger a build to test if we got it right? |
@yardenshoham what's the problem here? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how to test this so I'll explain my thought process:
After a discussion with @techknowlogick in cda2c38 I saw the CI config has this block:
gitea/.drone.yml
Lines 618 to 630 in cda2c38
I don't know much about Drone but after looking at appleboy/drone-git-push's source code, I think each setting becomes an environment variable (e.g.
remote
toPLUGIN_REMOTE
,commit_message
toPLUGIN_COMMIT_MESSAGE
etc...). Take a look at the code block loading the author info:https://github.com/appleboy/drone-git-push/blob/a69878c00665277c53fb38d6c5980221cb687935/main.go#L32-L42
Two environment variables are listed for each setting. This PR forces both to have the same value.