Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vitest tests to Gitpod #21449

Merged
merged 1 commit into from Oct 14, 2022
Merged

Conversation

yardenshoham
Copy link
Member

@yardenshoham yardenshoham commented Oct 13, 2022

The vitest PR is merged, we can now add vitest to Gitpod's testing pane

We couldn't use jest in the same manner because we had to customize NODE_OPTIONS.

Screenshot (look at all the cool stuff circled in red):
image

@silverwind silverwind added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 14, 2022
@yardenshoham yardenshoham force-pushed the vitest-gitpod branch 2 times, most recently from 366c628 to 5ad921d Compare October 14, 2022 09:46
@codecov-commenter
Copy link

Codecov Report

Merging #21449 (5ad921d) into main (9dc264a) will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #21449      +/-   ##
==========================================
+ Coverage   47.30%   47.60%   +0.29%     
==========================================
  Files        1023     1023              
  Lines      139337   139337              
==========================================
+ Hits        65910    66325     +415     
+ Misses      65448    65004     -444     
- Partials     7979     8008      +29     
Impacted Files Coverage Δ
models/git/protected_tag.go 51.47% <0.00%> (-16.18%) ⬇️
models/asymkey/gpg_key_common.go 52.63% <0.00%> (-3.95%) ⬇️
modules/queue/queue_channel.go 80.55% <0.00%> (-2.78%) ⬇️
models/perm/access/access.go 60.66% <0.00%> (-2.00%) ⬇️
models/issues/pull.go 50.20% <0.00%> (-1.85%) ⬇️
services/pull/pull.go 40.31% <0.00%> (+0.15%) ⬆️
services/gitdiff/gitdiff.go 68.13% <0.00%> (+0.94%) ⬆️
modules/charset/charset.go 73.91% <0.00%> (+2.17%) ⬆️
modules/util/timer.go 100.00% <0.00%> (+14.28%) ⬆️
services/migrations/github.go 64.01% <0.00%> (+63.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 14, 2022
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 14, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 14, 2022
@techknowlogick techknowlogick merged commit 6bb6a10 into go-gitea:main Oct 14, 2022
@yardenshoham yardenshoham deleted the vitest-gitpod branch October 14, 2022 15:25
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants