Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless appVer from JS window.config #21445

Merged
merged 1 commit into from Oct 13, 2022

Conversation

wxiaoguang
Copy link
Contributor

The only usage of appVer was in serviceworker.js, while indeed it needs the asset version.

@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 13, 2022
@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Oct 13, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 13, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 13, 2022
@wxiaoguang wxiaoguang merged commit f40833d into go-gitea:main Oct 13, 2022
@wxiaoguang wxiaoguang deleted the remove-js-appver branch October 13, 2022 17:16
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 14, 2022
* upstream/main:
  Add cynkra bronze sponsor (go-gitea#21325)
  Run `make fmt` (go-gitea#21437)
  Remove useless `appVer` from JS `window.config` (go-gitea#21445)
  Add support for Chocolatey/NuGet v2 API (go-gitea#21393)
  Fix go-gitea#21406: Hide repo information from file view/blame mode (go-gitea#21420)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants