Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run make fmt #21437

Merged
merged 1 commit into from Oct 14, 2022
Merged

Run make fmt #21437

merged 1 commit into from Oct 14, 2022

Conversation

yardenshoham
Copy link
Member

The only change is what make fmt did, I am merely a vessel for its glorious function

@yardenshoham yardenshoham changed the title Run "make fmt" Run make fmt Oct 13, 2022
silverwind
silverwind approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we end up with unformatted code on main branch? Normally, fmt-check should detect this and fail the build.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 13, 2022
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 13, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 13, 2022
@yardenshoham
Run "make fmt"
e6cc824 
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit c4f7c96 into go-gitea:main Oct 14, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 14, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
1bdcdad 
* upstream/main:
  Add cynkra bronze sponsor (go-gitea#21325)
  Run `make fmt` (go-gitea#21437)
  Remove useless `appVer` from JS `window.config` (go-gitea#21445)
  Add support for Chocolatey/NuGet v2 API (go-gitea#21393)
  Fix go-gitea#21406: Hide repo information from file view/blame mode (go-gitea#21420)
@yardenshoham yardenshoham deleted the fmt branch October 14, 2022 08:51
@yardenshoham yardenshoham mentioned this pull request Oct 14, 2022
Closed
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yardenshoham @techknowlogick @silverwind @a1012112796 @GiteaBot