Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use username instead of displayname in GetListLockHandler #21268

Closed
pezhovski opened this issue Sep 26, 2022 · 4 comments · Fixed by #21415
Closed

Use username instead of displayname in GetListLockHandler #21268

pezhovski opened this issue Sep 26, 2022 · 4 comments · Fixed by #21415
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@pezhovski
Copy link
Contributor

Feature Description

When listing lfs locks from command line, response contains display name in owner field
It could happen that the same display name may be used by several users and it becomes hard to distinguish owner of the lock without finding branch and file in web ui

This plugin relies on this field to determine if user can edit file and prevent conflicts later
https://github.com/ProjectBorealis/UEGitPlugin

Screenshots

No response
@pezhovski pezhovski added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Sep 26, 2022
@KN4CK3R
Copy link
Member

KN4CK3R commented Sep 26, 2022

The current implementation is following the example from the Git LFS docs.
https://github.com/git-lfs/git-lfs/blob/main/docs/api/locking.md#successful-response

Would Fullname (Username) help?

@pezhovski
Copy link
Contributor Author

Hello @KN4CK3R it would definitely help to distinguish users with same fullname, but in case of mentioned plugin it will require to place this combination in settings instead of just fullname, which, at least for me, seems more counter-intuitive.

@KN4CK3R
Copy link
Member

KN4CK3R commented Oct 10, 2022

Sure, but that's how the plugin works. What solution do you propose?

@pezhovski
Copy link
Contributor Author

Why don't just use username?

@KN4CK3R KN4CK3R mentioned this issue Oct 11, 2022
Merged
techknowlogick added a commit that referenced this issue Oct 12, 2022
@KN4CK3R @techknowlogick
Use Name instead of DisplayName in LFS Lock (#21415)
4dc3b2e 
Fixes #21268

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Name instead of DisplayName in LFS Lock KN4CK3R/gitea
2 participants
@KN4CK3R @pezhovski