Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure golangci-lint to show all issues #21106

Merged
merged 4 commits into from Sep 20, 2022

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Sep 7, 2022

golangci by default limits "same issues" to 3 which can be hindering when many issues are present. Change it to always show all issues.

golangci by default limits "same issues" to 3 which can be hindering
when many issues are present. Change it to always show all issues.
@silverwind silverwind added topic/code-linting skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 7, 2022
@silverwind silverwind added this to the 1.18.0 milestone Sep 7, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 7, 2022
@silverwind
Copy link
Member Author

I also added max-issues-per-linter: 0 which unrestricts the issues per linter which by default is limited to 50.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 9, 2022
@wxiaoguang wxiaoguang merged commit 3995144 into go-gitea:main Sep 20, 2022
@silverwind silverwind deleted the allissues branch September 20, 2022 10:08
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 22, 2022
* upstream/main:
  Use absolute links in feeds (go-gitea#21229)
  Prevent invalid behavior for file reviewing when loading more files (go-gitea#21230)
  Respect `REQUIRE_SIGNIN_VIEW` for packages (go-gitea#20873)
  Make Clone in VSCode link get updated correctly (go-gitea#21225)
  Configure golangci-lint to show all issues (go-gitea#21106)
  Fix user visible check (go-gitea#21210)
  Fix template bug of admin monitor (go-gitea#21208)
  Clarify that `ENABLE_SWAGGER` only influences the API docs, not the routes (go-gitea#21215)
  Enable fluid page layout on medium size viewports (go-gitea#21178)
  [API] teamSearch show teams with no members if user is admin (go-gitea#21204)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants