Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdownlint #20512

Merged
merged 2 commits into from Jul 28, 2022
Merged

Add markdownlint #20512

merged 2 commits into from Jul 28, 2022

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jul 27, 2022

Add markdownlint linter and fix issues. Config is based on the one from electron's repo with a few rules relaxed. Of note is that hard line breaks via double-space at the end of the line are forbidden, so markdown files can now be trimmed of all spaces.

A lot of changes are related to unordered list bullets. The rule is set for consistency, so it lints for the same style of bullets within one file.

Add `markdownlint` linter and fix issues. Config is based on the one
from electron's repo with a few rules relaxed.
@silverwind silverwind added topic/code-linting skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 27, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 28, 2022
@techknowlogick techknowlogick added this to the 1.18.0 milestone Jul 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 28, 2022
@wxiaoguang wxiaoguang merged commit ae52df6 into go-gitea:main Jul 28, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 28, 2022
* giteaofficial/main:
  Removed some vestigial code related to Range bounds checks (go-gitea#20312)
  Add markdownlint (go-gitea#20512)
  Fix possible panic when repository is empty (go-gitea#20509)
  patch (doc): add heading to ssh flow explanation (go-gitea#20506)
  Show hint to link package to repo when viewing empty repo package list (go-gitea#20504)
  Fix ROOT_URL detection for URLs without trailing slash (go-gitea#20502)
  Add Tar ZSTD support (go-gitea#20493)
@silverwind silverwind deleted the markdownlint branch July 28, 2022 07:53
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
Add `markdownlint` linter and fix issues. Config is based on the one
from electron's repo with a few rules relaxed.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants