Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spacing between the properties of the key #20145

Merged
merged 2 commits into from Jun 27, 2022
Merged

Add spacing between the properties of the key #20145

merged 2 commits into from Jun 27, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jun 26, 2022 •
edited

Before:
image

After:
image

@Gusted Gusted added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 26, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 26, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@5d3f99c). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #20145   +/-   ##
=======================================
  Coverage        ?   46.84%           
=======================================
  Files           ?      973           
  Lines           ?   134788           
  Branches        ?        0           
=======================================
  Hits            ?    63147           
  Misses          ?    63898           
  Partials        ?     7743

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d3f99c...e4302ea. Read the comment docs.

wxiaoguang
wxiaoguang approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (IMO using a list * might be good too, and it can avoid some editor's trimming trailing spaces behavior)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 27, 2022
@lunny
Copy link
Member

lunny commented Jun 27, 2022

LGTM

@lunny lunny merged commit 1f7c717 into go-gitea:main Jun 27, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 27, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a6e2da9 
* giteaofficial/main:
  Add spacing between the properties of the key (go-gitea#20145)
  Remove U2F support (go-gitea#20141)
  Make better use of i18n  (go-gitea#20096)
@Gusted Gusted deleted the fix-security-key branch June 27, 2022 14:27
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@Gusted @lunny
Add spacing between the properties of the key (go-gitea#20145)
1c5af86 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Gusted @codecov-commenter @lunny @wxiaoguang @delvh @GiteaBot