Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move eslintrc/stylelintrc to non-deprecated extensions #20110

Merged
merged 2 commits into from Jun 24, 2022
Merged

Move eslintrc/stylelintrc to non-deprecated extensions #20110

merged 2 commits into from Jun 24, 2022

Conversation

silverwind
Copy link
Member

Extensionless config files for these have been deprecated a long time ago, rename them.

@silverwind
Copy link
Member Author

silverwind commented Jun 23, 2022 •
edited

Note that both .yaml and .yml extensions are valid for these tools but I am a proponent of the recommended .yaml extension, thought other files in the root currently use .yml.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 23, 2022
@silverwind
Copy link
Member Author

CI failure is unrelated.

@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 23, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 24, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 24, 2022
@6543 6543 added this to the 1.18.0 milestone Jun 24, 2022
@6543
Copy link
Member

6543 commented Jun 24, 2022

🚀

@6543 6543 merged commit 48ef12b into go-gitea:main Jun 24, 2022
@silverwind silverwind deleted the yaml-ext branch June 24, 2022 12:38
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 24, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
2dbef35 
* giteaoffical/main:
  Move eslintrc/stylelintrc to non-deprecated extensions (go-gitea#20110)
  Allow manager logging to set SQL (go-gitea#20064)
  Replace pubkey with privkey in keys_ssh.tmpl (go-gitea#20112)
  Update security information to add a public gpg key to make sending encrypted message possible (go-gitea#20117)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@silverwind
Move eslintrc/stylelintrc to non-deprecated extensions (go-gitea#20110)
7fa3cd0
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silverwind @6543 @lunny @GiteaBot