Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for issue creating #2002

Merged
merged 1 commit into from
Jun 18, 2017
Merged

Add integration test for issue creating #2002

merged 1 commit into from
Jun 18, 2017

Conversation

typeless
Copy link
Contributor

No description provided.

@ethantkoenig
Copy link
Member

Would it be possible to check that the issue was actually created? (by models.AssertExistsAndLoadBean(..), or if that's not possible by making a GET request to view it)

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 18, 2017
@ethantkoenig
Copy link
Member

@typeless Also, thank you for adding integration tests! I appreciate your willingness to do unglamorous-but-important tasks like writing tests.

@typeless typeless force-pushed the add-integration-test-for-issues branch from 2c3396c to d8bbd9e Compare June 18, 2017 03:28
@typeless
Copy link
Contributor Author

@ethantkoenig I have added a GET request to check the existence of the issue page. And I don't quite understand how AssertExistsAndLoadBean is used here.

@lunny lunny added this to the 1.2.0 milestone Jun 18, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 18, 2017
@lunny
Copy link
Member

lunny commented Jun 18, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2017
@lunny lunny merged commit 4d2ea7d into go-gitea:master Jun 18, 2017
@typeless typeless deleted the add-integration-test-for-issues branch April 3, 2019 05:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@typeless @ethantkoenig @lunny @tboerger