Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use better message for consistency check #19672

Merged
merged 1 commit into from May 10, 2022
Merged

Use better message for consistency check #19672

merged 1 commit into from May 10, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented May 10, 2022

  • Don't log the reflect struct, but instead log the ID of the struct. This improves the error message, as you would actually know which row is the error.

Before:
image

After:
image

@Gusted
Use better message for consistency check
118aeda 
- Don't log the reflect struct, but instead log the ID of the struct.
This improves the error message, as you would actually know which row is
the error.
@Gusted Gusted added this to the 1.17.0 milestone May 10, 2022
@Gusted Gusted added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 10, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 10, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2022
@6543 6543 merged commit 9d0253a into go-gitea:main May 10, 2022
@Gusted Gusted deleted the improve-consitency-check branch May 10, 2022 14:18
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 10, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
4b153ba 
* giteaofficial/main:
  Use better message for consistency check (go-gitea#19672)
  Fix new release from tags list UI (go-gitea#19670)
  Update go deps (go-gitea#19665)
  [doctor] Add check/fix for bogus action rows (go-gitea#19656)
  [skip ci] Updated translations via Crowdin
  Add tooltip to pending PR comments (go-gitea#19662)
  Add Webfinger endpoint (go-gitea#19462)
  Update documentation to disable duration settings with -1 instead of 0 (go-gitea#19647)
  Set the LastModified header for raw files (go-gitea#18356)
  Don't select join table's columns (go-gitea#19660)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@Gusted @AbdulrhmnGhanem
Use better message for consistency check (go-gitea#19672)
47e0a0f 
- Don't log the reflect struct, but instead log the ID of the struct.
This improves the error message, as you would actually know which row is
the error.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gusted @lunny @6543 @GiteaBot