Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltip to pending PR comments #19662

Merged
merged 3 commits into from May 9, 2022
Merged

Add tooltip to pending PR comments #19662

merged 3 commits into from May 9, 2022

Conversation

jackHay22
Copy link
Contributor

Resolves #19661

  • When making a PR, comments that have not been submitted are marked as "pending." This change adds a tooltip to clarify the actions that must be taken in order to publish the comment. It also notes that the comment is not yet visible to other users.

Screenshots

Screen Shot 2022-05-09 at 12 02 00 PM

kdumontnu
kdumontnu approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 9, 2022
@6543 6543 added the topic/ui-interaction Change the process how users use Gitea instead of the visual appearance label May 9, 2022
@6543 6543 added this to the 1.17.0 milestone May 9, 2022
6543
6543 reviewed May 9, 2022
View reviewed changes
options/locale/locale_en-US.ini Outdated Show resolved Hide resolved
templates/repo/diff/comments.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2022
@6543 6543 changed the title add tooltip to pending PR comments Add tooltip to pending PR comments May 9, 2022
@6543 6543 merged commit 7e19200 into go-gitea:main May 9, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 10, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
4b153ba 
* giteaofficial/main:
  Use better message for consistency check (go-gitea#19672)
  Fix new release from tags list UI (go-gitea#19670)
  Update go deps (go-gitea#19665)
  [doctor] Add check/fix for bogus action rows (go-gitea#19656)
  [skip ci] Updated translations via Crowdin
  Add tooltip to pending PR comments (go-gitea#19662)
  Add Webfinger endpoint (go-gitea#19462)
  Update documentation to disable duration settings with -1 instead of 0 (go-gitea#19647)
  Set the LastModified header for raw files (go-gitea#18356)
  Don't select join table's columns (go-gitea#19660)
@6543 6543 mentioned this pull request Jun 21, 2022
Closed
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@jackHay22 @AbdulrhmnGhanem
Add tooltip to pending PR comments (go-gitea#19662)
e569058
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdumontnu kdumontnu kdumontnu approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui-interaction Change the process how users use Gitea instead of the visual appearance
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Add tooltip for pending PR comments
4 participants
@jackHay22 @kdumontnu @6543 @GiteaBot