Fix search by issue type #1914
Merged
Fix search by issue type #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethantkoenig
commented
Jun 8, 2017
| Count(new(Issue)) | ||
| case FilterModeCreate: | ||
| stats.OpenCount, err = countSession(opts). | ||
| And("poster_id = ?", opts.PosterID). |
There was a problem hiding this comment.
These conditions are already handled in countSession(..), so we don't need to repeat them again here.
| </span> | ||
| <div class="menu"> | ||
| <a class="{{if eq .ViewType "all"}}active{{end}} item" href="{{$.Link}}?q={{$.Keyword}}&type=all&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&milestone={{$.MilestoneID}}&assignee={{$.AssigneeID}}">{{.i18n.Tr "repo.issues.filter_type.all_issues"}}</a> | ||
| <a class="{{if eq .ViewType "assigned"}}active{{end}} item" href="{{$.Link}}?q={{$.Keyword}}&type=assigned&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&milestone={{$.MilestoneID}}&assignee={{.SignedUser.ID}}">{{.i18n.Tr "repo.issues.filter_type.assigned_to_you"}}</a> |
There was a problem hiding this comment.
assignee param updated to be .Signed.User.ID (might be hard to tell what the non-whitespace changes are)
2 tasks
|
Maybe some integration tests. |
tboerger
added
the
lgtm/need 2
|
@lunny Added an integration test |
ethantkoenig
force-pushed
the
fix/issue_type_search
branch
2 times, most recently
from
357435e
to
4053f83
Compare
|
It fails on postgresql with error |
ethantkoenig
force-pushed
the
fix/issue_type_search
branch
from
4053f83
to
f664256
Compare
|
@lafriks Fixed |
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1886.
Other fixes/changes:
GetIssueStats(..)GetIssueStats(..)